fix(material): add missing componentsMap to mockServer #700 #701
Conversation
WalkthroughThe recent changes enhance the JSON schemas for component definitions, particularly for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant TinyComponents
User->>App: Import components
App->>TinyComponents: Request TinyCheckbox, TinyCollapse, etc.
TinyComponents-->>App: Provide component definitions
App-->>User: Components available for use
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
chilingling
added
bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/design-core/public/mock/bundle.json (1)
8910-8912: TheexportNamechange fromSelecttoBreadcrumbhas not been consistently applied.There are still multiple occurrences of the old
exportName"Select" in the following files:
mockServer/src/mock/get/app-center/v1/apps/schema/918.jsonmockServer/src/services/appinfo.jsonmockServer/assets/json/bundle.jsonpackages/vue-generator/test/testcases/sfc/case01/componentsMap.jsonpackages/design-core/public/mock/bundle.jsonPlease ensure that all occurrences of the old
exportNameare updated to "Breadcrumb" to maintain consistency and avoid potential issues.Analysis chain
Verify the
exportNamechange fromSelecttoBreadcrumb.Ensure that this change aligns with the intended functionality and does not introduce any breaking changes.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the `exportName` change from `Select` to `Breadcrumb`. # Test: Search for the `exportName` usage. Expect: Only occurrences of the new `exportName`. rg --type json -A 5 $'"exportName": "Breadcrumb"'Length of output: 1007
Script:
#!/bin/bash # Description: Verify if there are any remaining occurrences of the old `exportName` "Select". # Test: Search for the old `exportName`. Expect: No occurrences of the old `exportName`. rg --type json -A 5 $'"exportName": "Select"'Length of output: 3466
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- mockServer/src/mock/get/app-center/v1/apps/schema/918.json (2 hunks)
- packages/design-core/public/mock/bundle.json (9 hunks)
Additional comments not posted (13)
mockServer/src/mock/get/app-center/v1/apps/schema/918.json (5)
1922-1926: LGTM! New component definition forTinyCheckboxis correct.The new component definition is consistent with other component definitions.
1985-1989: LGTM! New component definition forTinyCollapseis correct.The new component definition is consistent with other component definitions.
1992-1996: LGTM! New component definition forTinyCollapseItemis correct.The new component definition is consistent with other component definitions.
1999-2003: LGTM! New component definition forTinyBreadcrumbis correct.The new component definition is consistent with other component definitions.
2006-2010: LGTM! New component definition forTinyBreadcrumbItemis correct.The new component definition is consistent with other component definitions.
packages/design-core/public/mock/bundle.json (8)
26-27: LGTM! Destructuring import forElInputenhances usability.The addition of
"destructuring": trueforElInputis a good improvement.
307-308: LGTM! Destructuring import forElButtonenhances usability.The addition of
"destructuring": trueforElButtonis a good improvement.
629-630: LGTM! Destructuring import forElFormenhances usability.The addition of
"destructuring": trueforElFormis a good improvement.
1087-1088: LGTM! Destructuring import forElFormItemenhances usability.The addition of
"destructuring": trueforElFormItemis a good improvement.
1438-1439: LGTM! Destructuring import forElTableenhances usability.The addition of
"destructuring": trueforElTableis a good improvement.
2677-2678: LGTM! Destructuring import forElTableColumnenhances usability.The addition of
"destructuring": trueforElTableColumnis a good improvement.
14016-14019: LGTM! Enhanced schema forTinyBreadcrumbimproves option definition and processing.The modification to the
TinyBreadcrumbschema is a good improvement.
14274-14275: LGTM! Correct type usage foractiveproperty inTinyTimeLine.Changing the
activeproperty from a string to a number ensures correct type usage.
* fix(mockServer): mockServer page preview can't render element-plus element (#503) * fix(style): fix render error caused by inline style breaks (#526) * fix(metaComp): fix bug where metaHtmlText could set value to incorret schema children (#473) * fix(vue-generator): fix globalstate codegen error (#547) * fix(material): add componentsMap to app Schema after material build (#527) * fix: slot params missing double quote (#605) * fix: slot params missing double quote * fix: exclude nodemodule test case * fix: 修复onMouseover拼写错误 (#662) * fix: esbuild install failed on node v16 (#668) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: builtin components can't generate import statement with genSFCWithDefaultPlugin method (#656) * fix: esbuild install failed on nodev16 (#671) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json * fix(preview): multiple nested blocks cannot preview #663 (#665) * fix(material): add missing componentsMap to mockServer (#701) * fix(setting): fix bindEvent dialog visible can't work on tinyvue 3.17 (#715) * feat(download-code): support download zip for not support browsers (#703) * feat(download-code): support download zip for not support browsers * feat(download-code): support download zip for not support browsers - review * feat(download-code): support download zip for not support browsers - review * docs: update milestone (#728) * docs: update milestone * fix: tab * fix: abaolute canvas init inlineStyle should be string (#730) * fix(download): Optimize download logic and adapt to iframe (#739) * fix(download): Optimize download logic and adapt to iframe * feat(cdn): change cdn from onmicrosoft to unpkg (#750) * fix: 隐藏画布根节点的包裹元素的操作选项 (#492) * fix(script): translate log (#549) * fix: translate log * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: reset spacing cannot generate correct source code (#657) * fix: jsx slot modelvalue can't update value (#734) * fix: jsx slot modelvalue can't update value * fix: add unit test for updateModel event * fix(canvas): absolute dnd update position to schema. close #664 (#751) * fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 (#789) Co-authored-by: wangwenbing <11535041@qq.com> * fix(stylePanel): fix setting border-radius could not work on first time (#481) * fix(common): fix verify required (#787) * fix: mixed lifeCyclesContent when empty lifecycles (#810) close #806 修复生命周期为空时，取当前页面schema生命周期值的 bug --------- Co-authored-by: chilingling <26962197+chilingling@users.noreply.github.com> Co-authored-by: yeser <631300329@qq.com> Co-authored-by: wenmine <wwmmail@foxmail.com> Co-authored-by: Gene <Pacify.98@gmail.com> Co-authored-by: yaoyun8 <142570291+yaoyun8@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: bwrong <ibwrong@foxmail.com> Co-authored-by: wangwenbing <11535041@qq.com> Co-authored-by: Xie Jay <xiejay97@gmail.com>
* fix(mockServer): mockServer page preview can't render element-plus element (opentiny#503) * fix(style): fix render error caused by inline style breaks (opentiny#526) * fix(metaComp): fix bug where metaHtmlText could set value to incorret schema children (opentiny#473) * fix(vue-generator): fix globalstate codegen error (opentiny#547) * fix(material): add componentsMap to app Schema after material build (opentiny#527) * fix: slot params missing double quote (opentiny#605) * fix: slot params missing double quote * fix: exclude nodemodule test case * fix: 修复onMouseover拼写错误 (opentiny#662) * fix: esbuild install failed on node v16 (opentiny#668) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: builtin components can't generate import statement with genSFCWithDefaultPlugin method (opentiny#656) * fix: esbuild install failed on nodev16 (opentiny#671) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json * fix(preview): multiple nested blocks cannot preview opentiny#663 (opentiny#665) * fix(material): add missing componentsMap to mockServer (opentiny#701) * fix(setting): fix bindEvent dialog visible can't work on tinyvue 3.17 (opentiny#715) * feat(download-code): support download zip for not support browsers (opentiny#703) * feat(download-code): support download zip for not support browsers * feat(download-code): support download zip for not support browsers - review * feat(download-code): support download zip for not support browsers - review * docs: update milestone (opentiny#728) * docs: update milestone * fix: tab * fix: abaolute canvas init inlineStyle should be string (opentiny#730) * fix(download): Optimize download logic and adapt to iframe (opentiny#739) * fix(download): Optimize download logic and adapt to iframe * feat(cdn): change cdn from onmicrosoft to unpkg (opentiny#750) * fix: 隐藏画布根节点的包裹元素的操作选项 (opentiny#492) * fix(script): translate log (opentiny#549) * fix: translate log * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: reset spacing cannot generate correct source code (opentiny#657) * fix: jsx slot modelvalue can't update value (opentiny#734) * fix: jsx slot modelvalue can't update value * fix: add unit test for updateModel event * fix(canvas): absolute dnd update position to schema. close opentiny#664 (opentiny#751) * fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 (opentiny#789) Co-authored-by: wangwenbing <11535041@qq.com> * fix(stylePanel): fix setting border-radius could not work on first time (opentiny#481) * fix(common): fix verify required (opentiny#787) * fix: mixed lifeCyclesContent when empty lifecycles (opentiny#810) close opentiny#806 修复生命周期为空时，取当前页面schema生命周期值的 bug --------- Co-authored-by: chilingling <26962197+chilingling@users.noreply.github.com> Co-authored-by: yeser <631300329@qq.com> Co-authored-by: wenmine <wwmmail@foxmail.com> Co-authored-by: Gene <Pacify.98@gmail.com> Co-authored-by: yaoyun8 <142570291+yaoyun8@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: bwrong <ibwrong@foxmail.com> Co-authored-by: wangwenbing <11535041@qq.com> Co-authored-by: Xie Jay <xiejay97@gmail.com>
3 participants
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: #700
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Improvements
exportNamefor a previously defined package, indicating a rebranding.optionsproperty for TinyBreadcrumb for better definition and processing.activeproperty in TinyTimeLine for improved logic interpretation.