fix: esbuild install failed on nodev16 #671

chilingling · 2024-07-22T03:16:56Z

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)
Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Chores
- Removed unnecessary polyfills from the development dependencies to streamline the project.
- Added esbuild as a dependency to enhance build performance and capabilities.

coderabbitai · 2024-07-22T03:17:05Z

Walkthrough

The recent changes involve refining the development environment of the project. Two polyfill packages were removed to streamline the dependencies, while a new dependency on esbuild was introduced in the design-core package to enhance build performance. These adjustments aim to optimize the workflow by reducing unnecessary complexities and leveraging modern tools for improved efficiency.

Changes

Files	Change Summary
`package.json`, `packages/design-core/package.json`	Removed `@esbuild-plugins/node-globals-polyfill` and `@esbuild-plugins/node-modules-polyfill`; added `"esbuild": "^0.21.5"` to enhance build tooling.

Poem

In the garden, changes bloom,
Polyfills fade, making room,
esbuild hops in, swift and bright,
With faster builds, our code takes flight!
A tidy space for code to play,
Hooray for progress, hip-hip-hooray! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2c27f91 and 3ee2fb5.

Files selected for processing (2)

package.json (1 hunks)
packages/design-core/package.json (1 hunks)

Files skipped from review due to trivial changes (1)

package.json

Additional comments not posted (1)

packages/design-core/package.json (1)
110-110: LGTM! Verify the compatibility with Node.js version 16.

The addition of esbuild version ^0.21.5 is appropriate for enhancing the build process. Ensure that this version resolves the installation issues with Node.js version 16.

Verification successful

Verified: The addition of esbuild version ^0.21.5 is compatible with Node.js version 16, as specified in its engines field ("node": ">=12"). This version should resolve the installation issues with Node.js version 16.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify the compatibility of esbuild with Node.js version 16.

# Test: Check if the esbuild version 0.21.5 is compatible with Node.js version 16.
npm show [email protected] engines
Length of output: 104

Script:
#!/bin/bash
# Description: Verify the compatibility of esbuild with Node.js version 16 by inspecting its package.json file.

# Find the package.json file for esbuild version 0.21.5 and extract the engines field.
curl -s https://registry.npmjs.org/esbuild/0.21.5 | jq '.engines'
Length of output: 86

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3ee2fb5 and 2771f5c.

Files selected for processing (2)

package.json (1 hunks)
packages/design-core/package.json (1 hunks)

Files skipped from review as they are similar to previous changes (2)

package.json
packages/design-core/package.json

* fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json

* fix(mockServer): mockServer page preview can't render element-plus element (#503) * fix(style): fix render error caused by inline style breaks (#526) * fix(metaComp): fix bug where metaHtmlText could set value to incorret schema children (#473) * fix(vue-generator): fix globalstate codegen error (#547) * fix(material): add componentsMap to app Schema after material build (#527) * fix: slot params missing double quote (#605) * fix: slot params missing double quote * fix: exclude nodemodule test case * fix: 修复onMouseover拼写错误 (#662) * fix: esbuild install failed on node v16 (#668) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: builtin components can't generate import statement with genSFCWithDefaultPlugin method (#656) * fix: esbuild install failed on nodev16 (#671) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json * fix(preview): multiple nested blocks cannot preview #663 (#665) * fix(material): add missing componentsMap to mockServer (#701) * fix(setting): fix bindEvent dialog visible can't work on tinyvue 3.17 (#715) * feat(download-code): support download zip for not support browsers (#703) * feat(download-code): support download zip for not support browsers * feat(download-code): support download zip for not support browsers - review * feat(download-code): support download zip for not support browsers - review * docs: update milestone (#728) * docs: update milestone * fix: tab * fix: abaolute canvas init inlineStyle should be string (#730) * fix(download): Optimize download logic and adapt to iframe (#739) * fix(download): Optimize download logic and adapt to iframe * feat(cdn): change cdn from onmicrosoft to unpkg (#750) * fix: 隐藏画布根节点的包裹元素的操作选项 (#492) * fix(script): translate log (#549) * fix: translate log * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: reset spacing cannot generate correct source code (#657) * fix: jsx slot modelvalue can't update value (#734) * fix: jsx slot modelvalue can't update value * fix: add unit test for updateModel event * fix(canvas): absolute dnd update position to schema. close #664 (#751) * fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 (#789) Co-authored-by: wangwenbing <[email protected]> * fix(stylePanel): fix setting border-radius could not work on first time (#481) * fix(common): fix verify required (#787) * fix: mixed lifeCyclesContent when empty lifecycles (#810) close #806 修复生命周期为空时，取当前页面schema生命周期值的 bug --------- Co-authored-by: chilingling <[email protected]> Co-authored-by: yeser <[email protected]> Co-authored-by: wenmine <[email protected]> Co-authored-by: Gene <[email protected]> Co-authored-by: yaoyun8 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: bwrong <[email protected]> Co-authored-by: wangwenbing <[email protected]> Co-authored-by: Xie Jay <[email protected]>

* fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json

* fix(mockServer): mockServer page preview can't render element-plus element (opentiny#503) * fix(style): fix render error caused by inline style breaks (opentiny#526) * fix(metaComp): fix bug where metaHtmlText could set value to incorret schema children (opentiny#473) * fix(vue-generator): fix globalstate codegen error (opentiny#547) * fix(material): add componentsMap to app Schema after material build (opentiny#527) * fix: slot params missing double quote (opentiny#605) * fix: slot params missing double quote * fix: exclude nodemodule test case * fix: 修复onMouseover拼写错误 (opentiny#662) * fix: esbuild install failed on node v16 (opentiny#668) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: builtin components can't generate import statement with genSFCWithDefaultPlugin method (opentiny#656) * fix: esbuild install failed on nodev16 (opentiny#671) * fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json * fix(preview): multiple nested blocks cannot preview opentiny#663 (opentiny#665) * fix(material): add missing componentsMap to mockServer (opentiny#701) * fix(setting): fix bindEvent dialog visible can't work on tinyvue 3.17 (opentiny#715) * feat(download-code): support download zip for not support browsers (opentiny#703) * feat(download-code): support download zip for not support browsers * feat(download-code): support download zip for not support browsers - review * feat(download-code): support download zip for not support browsers - review * docs: update milestone (opentiny#728) * docs: update milestone * fix: tab * fix: abaolute canvas init inlineStyle should be string (opentiny#730) * fix(download): Optimize download logic and adapt to iframe (opentiny#739) * fix(download): Optimize download logic and adapt to iframe * feat(cdn): change cdn from onmicrosoft to unpkg (opentiny#750) * fix: 隐藏画布根节点的包裹元素的操作选项 (opentiny#492) * fix(script): translate log (opentiny#549) * fix: translate log * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Update scripts/connection.mjs Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: reset spacing cannot generate correct source code (opentiny#657) * fix: jsx slot modelvalue can't update value (opentiny#734) * fix: jsx slot modelvalue can't update value * fix: add unit test for updateModel event * fix(canvas): absolute dnd update position to schema. close opentiny#664 (opentiny#751) * fix(generate-vue):修复出码文件选择界面打包后样式丢失问题 (opentiny#789) Co-authored-by: wangwenbing <[email protected]> * fix(stylePanel): fix setting border-radius could not work on first time (opentiny#481) * fix(common): fix verify required (opentiny#787) * fix: mixed lifeCyclesContent when empty lifecycles (opentiny#810) close opentiny#806 修复生命周期为空时，取当前页面schema生命周期值的 bug --------- Co-authored-by: chilingling <[email protected]> Co-authored-by: yeser <[email protected]> Co-authored-by: wenmine <[email protected]> Co-authored-by: Gene <[email protected]> Co-authored-by: yaoyun8 <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: bwrong <[email protected]> Co-authored-by: wangwenbing <[email protected]> Co-authored-by: Xie Jay <[email protected]>

rhlin previously approved these changes Jul 22, 2024

View reviewed changes

coderabbitai bot reviewed Jul 22, 2024

View reviewed changes

chilingling added 3 commits July 22, 2024 01:07

fix: esbuild install failed on nodev16

2b66bc6

fix: esbuild install failed on nodev16

a143c87

fix: remove deps on root pkg.json

2771f5c

chilingling dismissed rhlin’s stale review via 2771f5c July 22, 2024 08:08

chilingling force-pushed the fix/esbuildInstall branch from 3ee2fb5 to 2771f5c Compare July 22, 2024 08:08

hexqi approved these changes Jul 22, 2024

View reviewed changes

coderabbitai bot reviewed Jul 22, 2024

View reviewed changes

hexqi merged commit fec563d into opentiny:develop Jul 22, 2024

hexqi pushed a commit to hexqi/tiny-engine that referenced this pull request Sep 21, 2024

fix: esbuild install failed on nodev16 (opentiny#671)

2d77e27

* fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json

yy-wow pushed a commit to yy-wow/tiny-engine that referenced this pull request Oct 10, 2024

fix: esbuild install failed on nodev16 (opentiny#671)

df9aaea

* fix: esbuild install failed on nodev16 * fix: esbuild install failed on nodev16 * fix: remove deps on root pkg.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: esbuild install failed on nodev16 #671

fix: esbuild install failed on nodev16 #671

Uh oh!

chilingling commented Jul 22, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: esbuild install failed on nodev16 #671

fix: esbuild install failed on nodev16 #671

Uh oh!

Conversation

chilingling commented Jul 22, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

Background and solution

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chilingling commented Jul 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 22, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)