Skip to content

[Docs & Bugs] Minor fixes post keybase changes#513

Merged
Olshansk merged 5 commits intomainfrom
minor_fixes
Feb 15, 2023
Merged

[Docs & Bugs] Minor fixes post keybase changes#513
Olshansk merged 5 commits intomainfrom
minor_fixes

Conversation

@Olshansk
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk commented Feb 15, 2023

Description

Fixing a few minor documentation related and linter related errors on main from recent changes.

Issue

Fixes #NA

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Tended to a few simple linter checks not addressed on main: added nolint
  • Add a BUG comment related to the keybase: doesn't work from built binary
  • Ran make generate_cli_commands_docs (after a minor fix) to update the swagger documentation
  • Fixed make send_local_tx to use accounts in the keybase

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@Olshansk Olshansk added the code health Nice to have code improvement label Feb 15, 2023
@Olshansk Olshansk requested review from h5law and okdas February 15, 2023 00:54
@Olshansk Olshansk self-assigned this Feb 15, 2023
@Olshansk Olshansk added bug Something isn't working - expected behaviour is incorrect documentation Improvements or additions to documentation labels Feb 15, 2023
h5law
h5law approved these changes Feb 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@h5law h5law left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@Olshansk Olshansk merged commit 8f8d4fb into main Feb 15, 2023
@Olshansk Olshansk deleted the minor_fixes branch February 15, 2023 01:02
bryanchriswhite added a commit that referenced this pull request Feb 20, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/libp2p
e8a19b9 
* pokt/main:
  [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522)
  Refactor/fix state sync logs (#515)
  [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521)
  [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520)
  [CLI] Stake command bugfix (#518)
  [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517)
  Fix the link shown by `make go_doc`
  Fixed duplicate GITHUB_WIKI tag
  [Documentation] Update Devlog Formatting (#512)
  [Docs & Bugs] Minor fixes post keybase changes (#513)
  [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503)
  [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501)
  update devlog2.md
  update devlog2.md
  Update devlog1.md
bryanchriswhite added a commit that referenced this pull request Feb 20, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/libp2p
b0dbfec 
* pokt/main:
  [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522)
  Refactor/fix state sync logs (#515)
  [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521)
  [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520)
  [CLI] Stake command bugfix (#518)
  [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517)
  Fix the link shown by `make go_doc`
  Fixed duplicate GITHUB_WIKI tag
  [Documentation] Update Devlog Formatting (#512)
  [Docs & Bugs] Minor fixes post keybase changes (#513)
  [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503)
  [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501)
  update devlog2.md
  update devlog2.md
  Update devlog1.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@okdas okdas Awaiting requested review from okdas

1 more reviewer

@h5law h5law h5law approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Olshansk Olshansk

Labels

bug Something isn't working - expected behaviour is incorrect code health Nice to have code improvement documentation Improvements or additions to documentation

Projects

V1 Dashboard
Status: Done

Milestone

M*: Pocket QoL (Quality of Life)

Development

Successfully merging this pull request may close these issues.

2 participants

@Olshansk @h5law