Skip to content

Refactor/fix state sync logs#515

Merged
gokutheengineer merged 20 commits intomainfrom
refactor/fix-state-sync-logs
Feb 17, 2023
Merged

Refactor/fix state sync logs#515
gokutheengineer merged 20 commits intomainfrom
refactor/fix-state-sync-logs

Conversation

@gokutheengineer
Copy link
Copy Markdown
Contributor

@gokutheengineer gokutheengineer commented Feb 15, 2023 •
edited
Loading

Description

Improves logs for the state sync submodule.

Issue

Fixes #514

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Add constant state sync message types to the consensus module types
  • Update logs and error messages of the state sync
  • Delete unnecessary server mode enabling op in app/pocket/main.go

Testing

  • make develop_test
  • LocalNet w/ all of the steps outlined in the README

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@gokutheengineer gokutheengineer self-assigned this Feb 15, 2023
@gokutheengineer gokutheengineer added the code health Nice to have code improvement label Feb 15, 2023
Olshansk
Olshansk requested changes Feb 15, 2023
View reviewed changes
gokutheengineer and others added 5 commits February 16, 2023 21:29
@gokutheengineer @Olshansk
Update consensus/types/types.go
224e17d 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update app/pocket/doc/CHANGELOG.md
dfe11a5 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/state_sync/module.go
c39a34f 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer
refactor log messages, rename file, some other nits
b5fbbb0
@gokutheengineer
golint error, update error logs
cd6f3c7
Olshansk
Olshansk requested changes Feb 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gokutheengineer Small suggestion on code style and also trying to stay consistent with the log messages.

The way you're using the fields is 💯 . Curious if you got benefit out of printing the entire proto request/response?

gokutheengineer and others added 9 commits February 17, 2023 12:38
@gokutheengineer @Olshansk
Update consensus/state_sync/module.go
ff8e076 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/state_sync/module.go
aae5a92 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/state_sync/server.go
a75fe0d 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/state_sync/server.go
5e5dcaa 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer @Olshansk
Update consensus/debugging.go
6a71c73 
Co-authored-by: Daniel Olshansky <olshansky@pokt.network>
@gokutheengineer
address comment, update changelog
00f137d
@gokutheengineer
Merge branch 'main' into refactor/fix-state-sync-logs
64b949c
@gokutheengineer
merge with main
2c56ce7
@gokutheengineer
Merge branch 'main' into refactor/fix-state-sync-logs
62ecd27
@gokutheengineer
Copy link
Copy Markdown
Contributor Author

gokutheengineer commented Feb 17, 2023 •
edited
Loading

Curious if you got benefit out of printing the entire proto request/response?

Definitely, it makes easier to read logs with the structure.

Olshansk
Olshansk approved these changes Feb 17, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last minor comment but otherwise, LGTM!

@gokutheengineer gokutheengineer merged commit e4267c4 into main Feb 17, 2023
@Olshansk Olshansk deleted the refactor/fix-state-sync-logs branch February 17, 2023 19:54
bryanchriswhite added a commit that referenced this pull request Feb 20, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/libp2p
e8a19b9 
* pokt/main:
  [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522)
  Refactor/fix state sync logs (#515)
  [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521)
  [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520)
  [CLI] Stake command bugfix (#518)
  [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517)
  Fix the link shown by `make go_doc`
  Fixed duplicate GITHUB_WIKI tag
  [Documentation] Update Devlog Formatting (#512)
  [Docs & Bugs] Minor fixes post keybase changes (#513)
  [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503)
  [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501)
  update devlog2.md
  update devlog2.md
  Update devlog1.md
bryanchriswhite added a commit that referenced this pull request Feb 20, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/libp2p
b0dbfec 
* pokt/main:
  [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522)
  Refactor/fix state sync logs (#515)
  [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521)
  [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520)
  [CLI] Stake command bugfix (#518)
  [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517)
  Fix the link shown by `make go_doc`
  Fixed duplicate GITHUB_WIKI tag
  [Documentation] Update Devlog Formatting (#512)
  [Docs & Bugs] Minor fixes post keybase changes (#513)
  [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503)
  [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501)
  update devlog2.md
  update devlog2.md
  Update devlog1.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Olshansk Olshansk Olshansk approved these changes

Assignees

@gokutheengineer gokutheengineer

Labels

code health Nice to have code improvement

Projects

V1 Dashboard
Status: Done

Milestone

M1: Pocket PoS (Proof of Stake)

Development

Successfully merging this pull request may close these issues.

[Refactor] Fix state sync logs

2 participants

@gokutheengineer @Olshansk