[Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) by deblasis · Pull Request #522 · pokt-network/pocket

deblasis · 2023-02-17T00:05:27Z

Description

This PR has been extracted from #491 and is, hopefully, more digestible from a code-review and scope point of view.

Issue

Fixes #490

Type of change

Please mark the relevant option(s):

List of changes

When nodes are added/removed from the Kubernetes Localnet, we stake/unstake them automatically
We achieve the above by dogfooding our own CLI inside Kubernetes

Testing

make develop_test
LocalNet w/ all of the steps outlined in the README

Required Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have tested my changes using the available tooling
I have updated the corresponding CHANGELOG

If Applicable Checklist

I have updated the corresponding README(s); local and/or global
I have added tests that prove my fix is effective or that my feature works
I have added, or updated, mermaid.js diagrams in the corresponding README(s)
I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

This reverts commit facca64.

…-network/pocket into issue/416-kiss-peer-discovery-light

…-discovery-light Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

…ster-manager Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

…anager

Olshansk

A few minor comments but otherwise LGTM!

app/client/doc/commands/client.md

build/localnet/cluster-manager/main.go

Olshansk · 2023-02-17T19:35:34Z

build/localnet/manifests/service-accounts.yaml

  name: debug-client-account
  namespace: default
+---
+apiVersion: v1


NIT: You use v1 in some places and the full rbac.authorization.k8s.io/v1 in others.

I realize they both point to the stable version but figured we could be consistent.

It doesn't work. One of the quirks of K8S I guess, cc: @okdas (TL;DR: it seems that Role and RoleBinding don't like apiVersion: v1)

I was getting kubernetes apply: error mapping /Role: no matches for kind "Role" in version "v1"

I stole the examples from here https://kubernetes.io/docs/reference/access-authn-authz/rbac/

build/localnet/cluster-manager/utils.go

build/localnet/cluster-manager/main.go

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

…ocket into issue/490-cluster-manager

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

…ocket into issue/490-cluster-manager

* pokt/main: [Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490) (#522) Refactor/fix state sync logs (#515) [P2P] KISS 2 - Peer discovery [Merge me after #520] - (Issues: #416, #429) (#521) [Core] KISS 1 - Finite State Machine [Merge me first] - (Issue: #499) (#520) [CLI] Stake command bugfix (#518) [CLI] Cannot run make localnet_client_debug: Cannot initialise the keybase with the validator keys: Unable to find YAML file (#517) Fix the link shown by `make go_doc` Fixed duplicate GITHUB_WIKI tag [Documentation] Update Devlog Formatting (#512) [Docs & Bugs] Minor fixes post keybase changes (#513) [Utility] Foundational bugs, tests, code cleanup and improvements (1 / 2) (#503) [Tooling] Integrate Keybase w/ CLI (Issue #484 ) (#501) update devlog2.md update devlog2.md Update devlog1.md

…ue: #498) (#523) ## Description This PR has been extracted from #491 and is, hopefully, more digestible from a code-review and scope point of view. This simply adds entrypoints and basic logic for node bootstrapping leveraging the finite state machine ## Issue Fixes #498 ## Type of change Please mark the relevant option(s): - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other  ## List of changes - Ability to fetch an addressbook from a bootstrap node(s) (by convention the first validator in LocalNet) - It's possible to override bootstrap nodes via CLI flag ## Testing - [x] `make develop_test` - [x] [LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md) w/ all of the steps outlined in the `README` ## Required Checklist - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have tested my changes using the available tooling - [x] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s) --------- Signed-off-by: Alessandro De Blasis <alex@deblasis.net> Co-authored-by: Dmitry K <okdas@pm.me> Co-authored-by: Dmitry Knyazev <okdas@users.noreply.github.com> Co-authored-by: Daniel Olshansky <olshansky@pokt.network> Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>

* pokt/main: [P2P] KISS 4 - Basic nodes bootstrapping [Merge me after #522] - (Issue: #498) (#523)

okdas and others added 30 commits December 13, 2022 16:07

Update Makefile

f0aa697

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

Update Makefile

8b50310

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

Update Makefile

52a44d7

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

requested changes so far

846ba6c

more requested changes

558768e

Merge branch 'main' into dk-localnet-pocket-operator

03f3ba3

some requested changes

5b824af

Merge branch 'main' into dk-localnet-pocket-operator

d53eded

add mermaid diagram

5225c3e

clarify location of the config files

b2cb5af

--wip-- [skip ci]

80d790d

localnet without operator

c94cb4f

Merge branch 'main' into dk-localnet-pocket-operator

78f09da

latest config

372bb6c

Merge branch 'main' into dk-localnet-pocket-operator

b92bc03

fully working operatorless localnet

1b103d7

auto update now works too

0f354d9

--wip-- [skip ci]

7631fd3

bump documentation

1d57ceb

change config a bit

ac40457

this is not needed anymore

06c8ef3

Merge branch 'main' into dk-localnet-pocket-operator

cba72f7

can scale validators automatically

a778f2c

change keys

2e47e2c

Merge branch 'main' into dk-localnet-pocket-operator

fa24420

also replace pubkeys

ebd5dd8

complete changing the keys // tests passed

defca3b

bring bck state hashes

03e5a04

Merge branch 'main' into dk-localnet-pocket-operator

36b1e5f

wip

19d6ba4

deblasis and others added 10 commits February 17, 2023 10:06

Update app/client/cli/utils.go

facca64

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

Update p2p/providers/addrbook_provider/rpc/provider.go

1a32c58

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

Revert "Update app/client/cli/utils.go"

b09edc2

This reverts commit facca64.

Merge branch 'issue/416-kiss-peer-discovery-light' of github.com:pokt…

918c466

…-network/pocket into issue/416-kiss-peer-discovery-light

refactor(rpc): updated getProtocolActorGetter for readability

c981eed

refactor(p2p): style in providers

06bb8d9

Merge remote-tracking branch 'upstream/main' into issue/416-kiss-peer…

c305aa6

…-discovery-light Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

fix(consensus): typo

f863e65

chore(p2p): providers readability improvement

96c1e0e

Merge branch 'issue/416-kiss-peer-discovery-light' into issue/490-clu…

b6c72f3

…ster-manager Signed-off-by: Alessandro De Blasis <alex@deblasis.net>

deblasis mentioned this pull request Feb 17, 2023

KISS Peer discovery, KISS Bootstrapping, Nodes auto-stake/unstake via K8S cluster-manager, Node Finite state machine - Issues #416, #490, #429, #498, #499 #491

Closed

16 tasks

deblasis added 2 commits February 17, 2023 11:06

Merge remote-tracking branch 'upstream/main' into issue/490-cluster-m…

57b4434

…anager

docs(cli): make generate_cli_commands_docs

4f1bef9

Base automatically changed from issue/416-kiss-peer-discovery-light to main February 17, 2023 18:51

Olshansk approved these changes Feb 17, 2023

View reviewed changes

deblasis and others added 8 commits February 17, 2023 21:36

Update build/localnet/cluster-manager/utils.go

64b5d7f

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

chore(cli): restored default home dir

2859596

chore(cli): renamed k8s import to pocketk8s

811bbf0

chore(cluster-manager): import aliases

6c37ab1

Merge branch 'issue/490-cluster-manager' of github.com:pokt-network/p…

050d516

…ocket into issue/490-cluster-manager

Update build/localnet/cluster-manager/utils.go

9032daa

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

docs(runtime): changelog

b0005e0

Merge branch 'issue/490-cluster-manager' of github.com:pokt-network/p…

b8b378d

…ocket into issue/490-cluster-manager

deblasis merged commit 6da420c into main Feb 17, 2023

deblasis deleted the issue/490-cluster-manager branch February 17, 2023 22:27

deblasis mentioned this pull request Feb 17, 2023

[CLI] Improve Keybase private-keys sourcing when running in Kubernetes #525

Closed

12 tasks

bryanchriswhite added a commit that referenced this pull request Feb 21, 2023

Merge remote-tracking branch 'pokt/main' into chore/libp2p

4510318

* pokt/main: [P2P] KISS 4 - Basic nodes bootstrapping [Merge me after #522] - (Issue: #498) (#523)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490)#522

[Infra] KISS 3 - Cluster Manager [Merge me after #521] - (Issues: #490)#522
deblasis merged 264 commits intomainfrom
issue/490-cluster-manager

deblasis commented Feb 17, 2023

Uh oh!

Olshansk left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Olshansk Feb 17, 2023

Uh oh!

deblasis Feb 17, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

deblasis commented Feb 17, 2023

Description

Issue

Type of change

List of changes

Testing

Required Checklist

If Applicable Checklist

Uh oh!

Olshansk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Olshansk Feb 17, 2023

Choose a reason for hiding this comment

Uh oh!

deblasis Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

deblasis Feb 17, 2023 •

edited

Loading