Skip to content

[Testing] [Tooling] chore: replace gocuke & go-mockdns in go.mod#782

Merged
bryanchriswhite merged 2 commits intomainfrom
chore/replace-deps
May 25, 2023
Merged

[Testing] [Tooling] chore: replace gocuke & go-mockdns in go.mod#782
bryanchriswhite merged 2 commits intomainfrom
chore/replace-deps

Conversation

@bryanchriswhite
Copy link
Copy Markdown
Collaborator

@bryanchriswhite bryanchriswhite commented May 23, 2023 •
edited
Loading

Description

Add replace directives for gocuke and go-mockdns forks/releases until upstream PRs are merged. Includes TECHDEBT comments for removal.

Issue

Extracted from #753

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other: swapping test dependencies for our own forks/releases thereof

List of changes

  • Replaced github.com/foxcpp/go-mockdns with github.com/pokt-network/go-mockdns v0.0.1
  • Replaced github.com/regen-network/gocuke with github.com/pokt-network/gocuke v0.0.1

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@bryanchriswhite bryanchriswhite added tooling tooling to support development, testing et al testing Defining, adding, automating or modifying tests small Pull request is small labels May 23, 2023
@bryanchriswhite bryanchriswhite self-assigned this May 23, 2023
@bryanchriswhite bryanchriswhite marked this pull request as ready for review May 23, 2023 19:47
Olshansk
Olshansk approved these changes May 23, 2023
View reviewed changes
go.mod

go 1.18

// TECHDEBT: remove once upstream PR is merged (see: https://github.com/regen-network/gocuke/pull/12)
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Contributor

@dylanlott dylanlott May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

dylanlott
dylanlott approved these changes May 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod

go 1.18

// TECHDEBT: remove once upstream PR is merged (see: https://github.com/regen-network/gocuke/pull/12)
Copy link
Copy Markdown
Contributor

@dylanlott dylanlott May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@bryanchriswhite bryanchriswhite merged commit 147c833 into main May 25, 2023
@bryanchriswhite bryanchriswhite deleted the chore/replace-deps branch May 25, 2023 21:18
bryanchriswhite added a commit that referenced this pull request May 26, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into refactor/message-handling
33b5b58 
* pokt/main:
  Update client to p1 in makefile
  change gitsha of private-keys.yaml (#787)
  Fix places where we request a password and don't check the nonInterac… (#788)
  [Testing] [Tooling] chore: replace `gocuke` & `go-mockdns` in go.mod (#782)
  [k8s] Rename `client` to `p1` in k8s localnet (#764)
  [Persistence] Refactors BlockStore Interface (#774)
  [BUG] Int casting issue when sending tx (#783)
  add public keys to private-keys.yaml (#779)
bryanchriswhite added a commit that referenced this pull request May 26, 2023
@bryanchriswhite
Merge branch 'refactor/message-handling' into refactor/nonce-deduper
f3b14b5 
* refactor/message-handling:
  Update client to p1 in makefile
  change gitsha of private-keys.yaml (#787)
  Fix places where we request a password and don't check the nonInterac… (#788)
  [Testing] [Tooling] chore: replace `gocuke` & `go-mockdns` in go.mod (#782)
  [k8s] Rename `client` to `p1` in k8s localnet (#764)
  [Persistence] Refactors BlockStore Interface (#774)
  [BUG] Int casting issue when sending tx (#783)
  fix: add  missing space to makefile
  add public keys to private-keys.yaml (#779)
  chore: update changelog
  chore: comment improvements
  fix: logger levels
  chore: improve func & var names'
  [Helm] Add ServiceMonitor to the helm chart (#767)
  Update PULL_REQUEST_TEMPLATE.md (#772)
  [CI/Infra] E2E tests on Argo Workflows (#737)
Olshansk pushed a commit that referenced this pull request Jun 1, 2023
@bryanchriswhite @Olshansk
[Testing] [Tooling] chore: replace gocuke & go-mockdns in go.mod (#…
eed6c4b 
…782)

## Description

Add replace directives for `gocuke` and `go-mockdns` forks/releases
until upstream PRs are merged. Includes `TECHDEBT` comments for removal.

## Issue

Extracted from #753

## Type of change

Please mark the relevant option(s):

- [ ] New feature, functionality or library
- [ ] Bug fix
- [ ] Code health or cleanup
- [ ] Major breaking change
- [ ] Documentation
- [x] Other: swapping test dependencies for our own forks/releases
thereof

## List of changes

<!-- REMOVE this comment block after following the instructions
 List out all the changes made
-->

- Replaced `github.com/foxcpp/go-mockdns` with
`github.com/pokt-network/go-mockdns v0.0.1`
- Replaced `github.com/regen-network/gocuke` with
`github.com/pokt-network/gocuke v0.0.1`

## Testing

- [ ] `make develop_test`; if any code changes were made
- [ ] `make test_e2e` on [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any code changes were made
- [ ] `e2e-devnet-test` passes tests on
[DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd);
if any code was changed
- [ ] [Docker Compose
LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
if any major functionality was changed or introduced
- [ ] [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any infrastructure or configuration changes were made

## Required Checklist

- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added, or updated, [`godoc` format
comments](https://go.dev/blog/godoc) on touched members (see:
[tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
- [ ] I have tested my changes using the available tooling
- [ ] I have updated the corresponding CHANGELOG

### If Applicable Checklist

- [ ] I have updated the corresponding README(s); local and/or global
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added, or updated,
[mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
README(s)
- [ ] I have added, or updated, documentation and
[mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
if I updated `shared/*`README(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Olshansk Olshansk Olshansk approved these changes

+1 more reviewer

@dylanlott dylanlott dylanlott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bryanchriswhite bryanchriswhite

Labels

small Pull request is small testing Defining, adding, automating or modifying tests tooling tooling to support development, testing et al waiting-for-review

Projects

V1 Dashboard
Status: Done

Milestone

M*: Pocket QoL (Quality of Life)

Development

Successfully merging this pull request may close these issues.

3 participants

@bryanchriswhite @Olshansk @dylanlott