Fix places where we request a password and don't check the nonInterac…#788
Merged
Fix places where we request a password and don't check the nonInterac…#788
Conversation
Olshansk
added
the
client
20 tasks
bryanchriswhite
added a commit
that referenced
this pull request
May 26, 2023
* pokt/main: Update client to p1 in makefile change gitsha of private-keys.yaml (#787) Fix places where we request a password and don't check the nonInterac… (#788) [Testing] [Tooling] chore: replace `gocuke` & `go-mockdns` in go.mod (#782) [k8s] Rename `client` to `p1` in k8s localnet (#764) [Persistence] Refactors BlockStore Interface (#774) [BUG] Int casting issue when sending tx (#783) add public keys to private-keys.yaml (#779)
bryanchriswhite
added a commit
that referenced
this pull request
May 26, 2023
* refactor/message-handling: Update client to p1 in makefile change gitsha of private-keys.yaml (#787) Fix places where we request a password and don't check the nonInterac… (#788) [Testing] [Tooling] chore: replace `gocuke` & `go-mockdns` in go.mod (#782) [k8s] Rename `client` to `p1` in k8s localnet (#764) [Persistence] Refactors BlockStore Interface (#774) [BUG] Int casting issue when sending tx (#783) fix: add missing space to makefile add public keys to private-keys.yaml (#779) chore: update changelog chore: comment improvements fix: logger levels chore: improve func & var names' [Helm] Add ServiceMonitor to the helm chart (#767) Update PULL_REQUEST_TEMPLATE.md (#772) [CI/Infra] E2E tests on Argo Workflows (#737)
Olshansk
added a commit
that referenced
this pull request
Jun 1, 2023
#788) ## Description ### Summary generated by Reviewpad on 25 May 23 21:27 UTC This pull request contains two patches. The first patch fixes an issue where the nonInteractive flag was not being checked when requesting passwords in a few places. The second patch updates the changelog to include the addition of the nonInteractive flag. ## Issue NA ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [ ] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Add the `nonInteractive` flag check where it was missing ## Testing - [ ] `make develop_test`; if any code changes were made - [ ] `make test_e2e` on [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any code changes were made - [ ] `e2e-devnet-test` passes tests on [DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd); if any code was changed - [ ] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [ ] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made <!-- REMOVE this comment block after following the instructions If you added additional tests or infrastructure, describe it here. Bonus points for images and videos or gifs. --> ## Required Checklist - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [ ] I have tested my changes using the available tooling - [ ] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 25 May 23 21:27 UTC
This pull request contains two patches. The first patch fixes an issue where the nonInteractive flag was not being checked when requesting passwords in a few places. The second patch updates the changelog to include the addition of the nonInteractive flag.
Issue
NA
Type of change
Please mark the relevant option(s):
List of changes
nonInteractiveflag check where it was missingTesting
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)