[CI/Infra] E2E tests on Argo Workflows by okdas · Pull Request #737 · pokt-network/pocket

okdas · 2023-05-10T19:41:06Z

Description

We've identified a need in argo workflow to allow to run e2e jobs in cluster, but as a part of GitHub CI jobs.

Issue

Fixes #718

Type of change

Please mark the relevant option(s):

List of changes

E2E tests to ensure the version of containers they run against prior to executing the test (done in protocol-infra repo)
Cluster manager cleans up the Pods managed by StatefulSets, if Pods are unhealthy and there is a new-er version of the software present.
Dedicated CI job to run E2E tests. That allows us to start the test from the GitHub UI, no need to push the new commit.

Testing

make develop_test; if any code changes were made
Docker Compose LocalNet; if any major functionality was changed or introduced
k8s LocalNet; if any infrastructure
or configuration changes were made
Remote DevNets

Required Checklist

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
I have tested my changes using the available tooling
I have updated the corresponding CHANGELOG

If Applicable Checklist

I have updated the corresponding README(s); local and/or global
I have added tests that prove my fix is effective or that my feature works
I have added, or updated, mermaid.js diagrams in the corresponding README(s)
I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

The check succeeded, dismissing the review comment.

okdas · 2023-05-17T23:49:28Z

@Olshansk I appreciate the feedback, the code is more readable now. I kept all comments related to rangeValCopy gocritic check open in case you'll want me to change the code in these places.

github-actions

The changelog validation failed with the following output:

Latest date in build/docs/CHANGELOG.md is incorrect.
Latest: 2023-05-17, Current: 2023-05-18

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

Olshansk

A couple more small NITS. Let's get it done and merge!

build/localnet/cluster-manager/crashed_pods_deleter.go

.github/workflows/e2e-test.yml

build/localnet/cluster-manager/crashed_pods_deleter.go

Olshansk · 2023-05-18T20:37:09Z

build/localnet/cluster-manager/crashed_pods_deleter.go

+			containerStatus := &pod.Status.ContainerStatuses[si]
+
+			// Only proceed if container is in some sort of Err status
+			if containerErroneousStatus(containerStatus) {


if !containerErroneousStatus(containerStatus) {
continue
}
// reduce the indent of everywhthing else

build/localnet/cluster-manager/crashed_pods_deleter.go

build/localnet/manifests/cluster-manager.yaml

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

github-actions

The changelog validation failed with the following output:

Missing changelog in module: app/

Missing changelog in module: consensus/

Missing changelog in module: persistence/

Missing changelog in module: shared/

Latest date in build/docs/CHANGELOG.md is incorrect.
Latest: 2023-05-17, Current: 2023-05-18

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

## Description Enhances the linter for inline error checks and alters existing error checks to be inline. ## Type of change Please mark the relevant option(s): - [x] Code health or cleanup ## List of changes - Introduces new custom linter - Changes existing code to be compliant with new linter rule ## Testing - [x] `make develop_test`; if any code changes were made - [ ] `make test_e2e` on [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any code changes were made - [ ] `e2e-devnet-test` passes tests on [DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd); if any code was changed - [ ] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [ ] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made ## Required Checklist - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [ ] I have tested my changes using the available tooling - [ ] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)

github-actions

The changelog validation failed with the following output:

Missing changelog in module: app/

Missing changelog in module: consensus/

Missing changelog in module: persistence/

Missing changelog in module: shared/

Latest date in build/docs/CHANGELOG.md is incorrect.
Latest: 2023-05-18, Current: 2023-05-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

github-actions

The changelog validation failed with the following output:

Latest date in build/docs/CHANGELOG.md is incorrect.
Latest: 2023-05-18, Current: 2023-05-19

Changelog verification failed. See error messages for more detail.

Please update the relevant CHANGELOG.md files and ensure they follow the correct format.

Olshansk

Great job and quick turnaround. Thanks @okdas!

Cc @h5law who should be unblocked once this merges in.

* pokt/main: [Helm] Add ServiceMonitor to the helm chart (#767) Update PULL_REQUEST_TEMPLATE.md (#772) [CI/Infra] E2E tests on Argo Workflows (#737)

## Description We've identified a need in argo workflow to allow to run e2e jobs in cluster, but as a part of GitHub CI jobs. ## Issue Fixes #718 ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [x] Infrastructure - [x] CI/CD ## List of changes - [x] E2E tests to ensure the version of containers they run against prior to executing the test (done in [protocol-infra repo](https://github.com/pokt-network/protocol-infra/blob/main/charts/v1-network-base/templates/e2e-tests.yaml#L30)) - [x] Cluster manager cleans up the Pods managed by StatefulSets, if Pods are unhealthy and there is a new-er version of the software present. - [x] Dedicated CI job to run E2E tests. That allows us to start the test from the GitHub UI, no need to push the new commit. ## Testing - [x] `make develop_test`; if any code changes were made - [ ] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [x] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made - [x] Remote DevNets ## Required Checklist - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [ ] I have tested my changes using the available tooling - [ ] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s) --------- Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

* refactor/message-handling: Update client to p1 in makefile change gitsha of private-keys.yaml (#787) Fix places where we request a password and don't check the nonInterac… (#788) [Testing] [Tooling] chore: replace `gocuke` & `go-mockdns` in go.mod (#782) [k8s] Rename `client` to `p1` in k8s localnet (#764) [Persistence] Refactors BlockStore Interface (#774) [BUG] Int casting issue when sending tx (#783) fix: add missing space to makefile add public keys to private-keys.yaml (#779) chore: update changelog chore: comment improvements fix: logger levels chore: improve func & var names' [Helm] Add ServiceMonitor to the helm chart (#767) Update PULL_REQUEST_TEMPLATE.md (#772) [CI/Infra] E2E tests on Argo Workflows (#737)

test 1

64eb38f

okdas added the infra Core infrastructure - not protocol related label May 10, 2023

okdas added this to the M2: Pocket DoS (Devnet of Servicers) milestone May 10, 2023

okdas self-assigned this May 10, 2023

reviewpad bot added the medium label May 10, 2023

okdas added 2 commits May 10, 2023 12:58

test

9484791

try token

86c92c8

reviewpad bot added large and removed medium labels May 10, 2023

okdas added 5 commits May 10, 2023 13:33

try to submit

bd02e3f

use GITHUB_WORKSPACE

8b8ac77

troubleshoot

593ee08

troubleshoot

e5951ab

test this

192c154

reviewpad bot added medium and removed large labels May 10, 2023

okdas added 4 commits May 10, 2023 14:12

try this

bd8eeaf

added perms

cc9c0f0

Empty-Commit

e4bdc03

Empty-Commit

6238b95

okdas added the push-image Build and push a container image on non-main builds label May 11, 2023

okdas added 2 commits May 10, 2023 18:01

put it all together

674055c

try without artifacts

271f321

reviewpad bot added large and removed medium labels May 11, 2023

okdas added 2 commits May 10, 2023 18:28

safedump

acb9d29

add cluster manager sts pods kill

9c489f2

okdas added the e2e-devnet-test Runs E2E tests on devnet label May 12, 2023

time limit wait-for-infra

3dc987c

reviewpad bot removed the large label May 12, 2023

remove unused sa

e1a66e9

okdas requested a review from Olshansk May 17, 2023 23:46

update pointers

6de718c

github-actions bot requested changes May 18, 2023

View reviewed changes

Olshansk requested changes May 18, 2023

View reviewed changes

Update .github/workflows/e2e-test.yml

5b0da95

Co-authored-by: Daniel Olshansky <olshansky@pokt.network>

github-actions bot requested changes May 18, 2023

View reviewed changes

okdas and others added 3 commits May 18, 2023 17:43

requested changes

6bc8ee2

nump changelog

535246f

reviewpad bot added large Pull request is large and removed medium Pull request is medium labels May 19, 2023

github-actions bot requested changes May 19, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into e2e-automation

1e6aad9

reviewpad bot added medium Pull request is medium and removed large Pull request is large labels May 19, 2023

github-actions bot requested changes May 19, 2023

View reviewed changes

okdas requested a review from Olshansk May 19, 2023 00:45

Olshansk approved these changes May 19, 2023

View reviewed changes

okdas merged commit 470f4fe into main May 19, 2023

okdas deleted the e2e-automation branch May 19, 2023 18:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI/Infra] E2E tests on Argo Workflows#737

[CI/Infra] E2E tests on Argo Workflows#737
okdas merged 35 commits intomainfrom
e2e-automation

okdas commented May 10, 2023 •

edited

Loading

Uh oh!

okdas commented May 17, 2023

Uh oh!

github-actions bot left a comment

Uh oh!

Olshansk left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Olshansk May 18, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Olshansk left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

okdas commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue

Type of change

List of changes

Testing

Required Checklist

If Applicable Checklist

Uh oh!

okdas commented May 17, 2023

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Olshansk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Olshansk May 18, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Olshansk left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

okdas commented May 10, 2023 •

edited

Loading