c/topic_table: use chunked_hash_map for lifecycle markers#29269
Merged
piyushredpanda merged 1 commit intoredpanda-data:devfrom Jan 16, 2026
Merged
c/topic_table: use chunked_hash_map for lifecycle markers#29269piyushredpanda merged 1 commit intoredpanda-data:devfrom
piyushredpanda merged 1 commit intoredpanda-data:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces absl::node_hash_map with chunked_hash_map for lifecycle markers storage to prevent oversized memory allocations. The change affects both the runtime topic_table and the snapshot data structure topics_t.
Changes:
- Updated lifecycle markers container type from
absl::node_hash_maptochunked_hash_map - Modified snapshot application logic to use
replace()method instead of direct assignment - Applied the change consistently across both the topic table and controller snapshot structures
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/v/cluster/topic_table.h | Changed lifecycle_markers_t typedef from absl::node_hash_map to chunked_hash_map |
| src/v/cluster/topic_table.cc | Updated snapshot application to use replace() with .values().copy() instead of direct assignment |
| src/v/cluster/controller_snapshot.h | Changed lifecycle markers type in topics_t struct from absl::node_hash_map to chunked_hash_map |
to avoid oversized allocations
8c7838e to
efc8a80
Compare
Collaborator
Retry command for Build#79095please wait until all jobs are finished before running the slash command |
Collaborator
CI test resultstest results on build#79095
|
bharathv
approved these changes
Jan 15, 2026
joe-redpanda
approved these changes
Jan 15, 2026
mmaslankaprv
approved these changes
Jan 16, 2026
Contributor
Author
|
/ci-repeat 1 |
Collaborator
|
/backport v25.3.x |
Collaborator
|
/backport v25.2.x |
Collaborator
|
/backport v25.1.x |
Collaborator
|
Failed to create a backport PR to v25.1.x branch. I tried: |
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid oversized allocations
Fixes https://redpandadata.atlassian.net/browse/CORE-15289
Backports Required
Release Notes