Skip to content

Comments

Add top-level id-token permissions for reusable workflow calls#2006

Open
TravisStark wants to merge 164 commits intotest-amazon-linux-2023from
tjstark/test-amazon-linux-2023
Open

Add top-level id-token permissions for reusable workflow calls#2006
TravisStark wants to merge 164 commits intotest-amazon-linux-2023from
tjstark/test-amazon-linux-2023

Conversation

@TravisStark
Copy link
Contributor

@TravisStark TravisStark commented Feb 6, 2026

Description of the issue

Fixes this workflow failure
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/21764547200

Description of changes

How does this change address the problem?

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Describe what tests you have done.

Requirements

Before commiting your code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

Integration Tests

To run integration tests against this PR, add the ready for testing label.

AsakerMohd and others added 30 commits May 7, 2025 12:31
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Lisa Guo <lisaguo@amazon.com>
# Description of the issue
This PR fixes a panic issue described in #1702.

# Description of changes
`golang.org/x/text/cases.Caser.String` is not goroutine safe. In this PR, we initialize a new Caser when a metric processed by Application Signals is found with camel case naming.

# License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
…r OTLP in EC2 (#1700)

Co-authored-by: Dominic Sciascia <dscia@amazon.com>
Co-authored-by: Dominic Sciascia <duhminick@users.noreply.github.com>
# Description of the issue
ApplicationSignalsProcessor relies on the resource attribute `deployment.environment` as a customer-provided override for ApplicationSignals `Environment`. However, `deployment.environment` has been deprecated and replaced with `deployment.environment.name` in the upstream.

# Description of changes
In this PR, we are adding support for the new attribute, while maintaining support for the old attribute, since customers may still specify `deployment.environment`, for example, if they are running on older OTEL versions.

Callout: We are no longer getting these attribute names from semconv as:
1. We were relying on go.opentelemetry.io/collector/semconv/v1.22.0, which does not have `deployment.environment.name`
2. https://pkg.go.dev/go.opentelemetry.io/collector/semconv has been deprecated
3. It's replacement, https://pkg.go.dev/go.opentelemetry.io/otel/semconv does not include `deployment.environment.name`: https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-go+deployment.environment.name&type=code
4. Nor does it include `deployment.environment` in the latest releases (1.3x): https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-go+deployment.environment&type=code

So we hardcode these attributes within the processor logic.
Paramadon and others added 24 commits November 14, 2025 08:34
Co-authored-by: Akansha Agarwal <agarakan@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jeffrey Chien <chienjef@amazon.com>
Co-authored-by: Marcus Mann <mpmann@amazon.com>
Co-authored-by: Adnan Khan <AdnaneKhan@users.noreply.github.com>
@TravisStark TravisStark requested a review from a team as a code owner February 6, 2026 20:32
@TravisStark TravisStark force-pushed the tjstark/test-amazon-linux-2023 branch from 9c7567f to 8df9d55 Compare February 8, 2026 17:02
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.