Skip to content

Comments

Cherry-picks for 2.12.4-RC.1#7702

Merged
neilalexander merged 20 commits intorelease/v2.12.4from
backports/v2.12.4-RC.1
Jan 6, 2026
Merged

Cherry-picks for 2.12.4-RC.1#7702
neilalexander merged 20 commits intorelease/v2.12.4from
backports/v2.12.4-RC.1

Conversation

MauriceVanVeen and others added 20 commits January 6, 2026 12:19
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This commit fixes single node election: previously, a single
node would simply store its vote, and never check if it
already reached a majority. So it would never transition to
the leader state.

Signed-off-by: Daniele Sciascia <daniele@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Previously creating a `ConsumerStore` required taking the stream lock to
determine whether the parent stream store was closed or not. Switch to
an atomic so that this no longer requires the lock.

This should speed up creating consumers in a system where the streams are
heavily loaded or contended.

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner January 6, 2026 12:23
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 3c0605b into release/v2.12.4 Jan 6, 2026
111 of 114 checks passed
@neilalexander neilalexander deleted the backports/v2.12.4-RC.1 branch January 6, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants