De-flake TestJetStreamBackOffCheckPending#7686
Merged
neilalexander merged 1 commit intomainfrom Jan 1, 2026
Merged
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
This was referenced Jan 6, 2026
neilalexander
added a commit
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestJetStreamBackOffCheckPendingcould flake sincecheckPendingcan run either 2 or 3 times depending on timing.o.resetPtmr(250ms)is called, ando.trackPendingshortly after when the redelivery happens. IfcheckPendingruns normally there will be 2 invocations toFastState, however ifcheckPendingran a few microseconds earlier (when compared with theo.trackPendingcall not the initial delay call), this will schedulecheckPendingto run again after minimal delay (to ensure the next redelivery is properly scheduled after the full delay), but that would mean 3 invocations which made the test fail.The test was originally added to ensure
checkPendinghas awareness of backoff and does not run too often. This test would fail with 10+ invocations without that, so this test actually needed to be updated. Also updatedo.trackPendingto ensure the timer and pending data use the same 'now' time.Signed-off-by: Maurice van Veen github@mauricevanveen.com