NRG: Leader resurrects removed peers on restarts#7602
Merged
neilalexander merged 1 commit intomainfrom Dec 2, 2025
Merged
Conversation
When removing a peer through ProposePeerRemove, the leader would not write its peer state file. So prior to this patch, it was possible for a leader to restart and populate peer and quorum information from an old peerstate file. Effectively forgetting membership changes that were committed before a restart. Signed-off-by: Daniele Sciascia <daniele@nats.io>
neilalexander
added a commit
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing a peer through ProposePeerRemove, the leader would not write its peer state file. So prior to this patch, it was possible for a leader to restart and populate peer and quorum information from an old peerstate file. Effectively forgetting membership changes that were committed before a restart.
Signed-off-by: Daniele Sciascia daniele@nats.io