Skip to content

Comments

NRG: do not count messages from removed peers towards quorum#7589

Merged
neilalexander merged 1 commit intomainfrom
raft-membership-fixes
Dec 1, 2025
Merged

NRG: do not count messages from removed peers towards quorum#7589
neilalexander merged 1 commit intomainfrom
raft-membership-fixes

Conversation

@sciascid
Copy link
Contributor

@sciascid sciascid commented Nov 28, 2025

Ignore appendEntryResponse from removed peers.

Signed-off-by: Daniele Sciascia daniele@nats.io

Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniele Sciascia <daniele@nats.io>
@sciascid sciascid force-pushed the raft-membership-fixes branch from 900f602 to efabcbf Compare December 1, 2025 10:43
@sciascid sciascid marked this pull request as ready for review December 1, 2025 10:44
@sciascid sciascid requested a review from a team as a code owner December 1, 2025 10:44
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 2939985 into main Dec 1, 2025
90 of 92 checks passed
@neilalexander neilalexander deleted the raft-membership-fixes branch December 1, 2025 13:38
neilalexander added a commit that referenced this pull request Dec 5, 2025
Includes the following:

- #7581
- #7585
- #7586
- #7565
- #7588
- #7593
- #7589
- #7594
- #7595
- #7596
- #7597
- #7598
- #7600
- #7601
- #7602
- #7604
- #7605
- #7607
- #7609
- #7610
- #7616
- #7614

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Jan 6, 2026
Includes the following:

- #7565
- #7589
- #7600
- #7602
- #7609
- #7610
- #7632
- #7649
- #7642
- #7658
- #7659
- #7661
- #7662
- #7663
- #7668
- #7683
- #7685
- #7686
- #7678
- #7691
- #7696
- #7698
- #7699
- #7700

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants