Conversation
sciascid
force-pushed
the
raft-leader-peer-remove
branch
from
08c8f0b to
6211f1c
Compare
server/raft_test.go
Outdated
|
|
||
| newLeader := rg.waitOnLeader() | ||
| require_True(t, leader.State() == Closed) | ||
| require_True(t, leader.ID() != newLeader.node().ID()) |
Member
There was a problem hiding this comment.
Minor nit, but require_Equal and require_NotEqual are better for these cases. That way if the assertion fails, the log line contains much more useful information.
Revisit quorum counting in `trackPeer` so that the implicit ack from the leader is counted only if the node is still part of the membership. So the corresponsing EntryPeerRemove message must be replicated to a majority of the new membership, not including the leader to be removed. When the leader commits an EntryPeerRemove message that removes the leader itself, attempt a proper step-down to a new leader, before stopping. Signed-off-by: Daniele Sciascia <daniele@nats.io>
sciascid
force-pushed
the
raft-leader-peer-remove
branch
from
6211f1c to
d88e9e8
Compare
neilalexander
added a commit
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revisit quorum counting in
trackPeerso that the implicit ack from the leader is counted only if the node is still part of the membership. So the corresponsing EntryPeerRemove message must be replicated to a majority of the new membership, not including the leader to be removed.When the leader commits an EntryPeerRemove message that removes the leader itself, attempt a proper step-down to a new leader, before stopping.
Signed-off-by: Daniele Sciascia daniele@nats.io