NRG: prevent peer remove of the last peer#7610
Merged
neilalexander merged 1 commit intomainfrom Dec 4, 2025
Merged
Conversation
Make sure that a Raft cluster cannot remove its last remaining peer. Attempting to remove the last peer will now return an error, preventing the cluster from entering an invalid state. Test TestNRGProposeRemovePeerFollowers has been renamed to TestNRGProposeRemovePeerFollowers and updated to cover this new behavior, specifically testing the scenario where an attempt is made to remove the leader when it is the only remaining peer. Signed-off-by: Daniele Sciascia <daniele@nats.io>
sciascid
force-pushed
the
raft-prevent-remove-last-peer
branch
from
ae60841 to
0e0ab6f
Compare
neilalexander
added a commit
that referenced
this pull request
Dec 5, 2025
neilalexander
added a commit
that referenced
this pull request
Dec 18, 2025
Includes the following: - #7553 - #7555 - #7579 - #7578 - #7581 - #7585 - #7586 - #7588 - #7593 - #7594 - #7595 - #7596 - #7597 - #7598 - #7601 - #7604 - #7605 - #7610 - #7616 - #7614 - #7622 - #7619 - #7624 - #7625 - #7627 - #7636 - #7637 - #7643 - #7648 - #7634 - #7655 - #7656 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that a Raft cluster cannot remove its last remaining peer. Attempting to remove the last peer will now return an error, preventing the cluster from entering an invalid state.
Test TestNRGProposeRemovePeerFollowers has been renamed to TestNRGProposeRemovePeerFollowers and updated to cover this new behavior, specifically testing the scenario where an attempt is made to remove the leader when it is the only remaining peer.
Signed-off-by: Daniele Sciascia daniele@nats.io