Add WebSocket-specific ping interval configuration option#7614
Merged
neilalexander merged 1 commit intomainfrom Dec 5, 2025
Merged
Add WebSocket-specific ping interval configuration option#7614neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
This commit adds a new PingInterval field to WebsocketOpts that allows
setting a custom ping interval specifically for WebSocket connections,
independent from the default NATS client ping interval.
```
websocket {
port: 8080
ping_interval: "30s"
}
```
Signed-off-by: Waldemar Quevedo <wally@nats.io>
alexbozhenko
reviewed
Dec 4, 2025
| o.ReconnectErrorReports = int(v.(int64)) | ||
| case "websocket", "ws": | ||
| if err := parseWebsocket(tk, o, errors); err != nil { | ||
| if err := parseWebsocket(tk, o, errors, warnings); err != nil { |
Member
There was a problem hiding this comment.
So we got this warning populated in the parseWebsocket (wired interface, btw), but we never used it.
Looks like we need to print them in
Line 864 in e3dcbfd
Member
Author
There was a problem hiding this comment.
they are printed here: https://github.com/nats-io/nats-server/blob/main/server/opts.go#L6180-L6190
neilalexander
added a commit
that referenced
this pull request
Dec 5, 2025
neilalexander
added a commit
that referenced
this pull request
Dec 18, 2025
Includes the following: - #7553 - #7555 - #7579 - #7578 - #7581 - #7585 - #7586 - #7588 - #7593 - #7594 - #7595 - #7596 - #7597 - #7598 - #7601 - #7604 - #7605 - #7610 - #7616 - #7614 - #7622 - #7619 - #7624 - #7625 - #7627 - #7636 - #7637 - #7643 - #7648 - #7634 - #7655 - #7656 Signed-off-by: Neil Twigg <neil@nats.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to set a custom ping interval specifically for WebSocket connections, independent from the default NATS client ping interval:
Signed-off-by: Waldemar Quevedo wally@nats.io