Skip to content

Fix data race in processClusterCreateStream#7586

Merged
neilalexander merged 1 commit intomainfrom
maurice/race-sa-created
Nov 27, 2025
Merged

Fix data race in processClusterCreateStream#7586
neilalexander merged 1 commit intomainfrom
maurice/race-sa-created

Conversation

@MauriceVanVeen
Copy link
Member

@MauriceVanVeen MauriceVanVeen commented Nov 27, 2025 

 WARNING: DATA RACE
Write at 0x00c000338c68 by goroutine 67408:
  github.com/nats-io/nats-server/v2/server.TestJetStreamClusterStreamHealthCheckMustNotRecreate.func3()
      /home/runner/work/nats-server/nats-server/server/jetstream_cluster_1_test.go:7273 +0x2d6

Previous read at 0x00c000338c68 by goroutine 67493:
  github.com/nats-io/nats-server/v2/server.(*jetStream).processClusterCreateStream()
      /home/runner/work/nats-server/nats-server/server/jetstream_cluster.go:4566 +0x1b56

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
Fix data race in processClusterCreateStream
8d38b27 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 27, 2025 13:57
neilalexander
neilalexander approved these changes Nov 27, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 919166e into main Nov 27, 2025
110 of 114 checks passed
@neilalexander neilalexander deleted the maurice/race-sa-created branch November 27, 2025 14:58
@neilalexander neilalexander mentioned this pull request Dec 5, 2025
Merged
neilalexander added a commit that referenced this pull request Dec 5, 2025
@neilalexander
Cherry-picks for 2.12.3-RC.2 (#7617)
951f08f 
Includes the following:

- #7581
- #7585
- #7586
- #7565
- #7588
- #7593
- #7589
- #7594
- #7595
- #7596
- #7597
- #7598
- #7600
- #7601
- #7602
- #7604
- #7605
- #7607
- #7609
- #7610
- #7616
- #7614

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander mentioned this pull request Dec 18, 2025
Merged
neilalexander added a commit that referenced this pull request Dec 18, 2025
@neilalexander
Cherry-picks for 2.11.12-RC.1 (#7669)
34fcec2 
Includes the following:

- #7553
- #7555
- #7579
- #7578
- #7581
- #7585
- #7586
- #7588
- #7593
- #7594
- #7595
- #7596
- #7597
- #7598
- #7601
- #7604
- #7605
- #7610
- #7616
- #7614
- #7622
- #7619
- #7624
- #7625
- #7627
- #7636
- #7637
- #7643
- #7648
- #7634
- #7655
- #7656

Signed-off-by: Neil Twigg <neil@nats.io>
@claude claude bot mentioned this pull request Feb 27, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MauriceVanVeen @neilalexander