Skip to content

Comments

[FIXED] MQTT: Timing out waiting to load x retained messages#7616

Merged
neilalexander merged 1 commit intomainfrom
mqtt_restore_retained_msgs
Dec 5, 2025
Merged

[FIXED] MQTT: Timing out waiting to load x retained messages#7616
neilalexander merged 1 commit intomainfrom
mqtt_restore_retained_msgs

Conversation

@kozlovic
Copy link
Member

@kozlovic kozlovic commented Dec 4, 2025

This could happen even if the server restored all retained messages. The issue was caused by the fact that the check to see if all were restored was based on the message sequence matching the last sequence of the retained message stream, as opposed to the number of messages in the stream.

Signed-off-by: Ivan Kozlovic ivan@synadia.com

This could happen even if the server restored all retained messages.
The issue was caused by the fact that the check to see if all were
restored was based on the message sequence matching the last sequence
of the retained message stream, as opposed to the number of messages
in the stream.

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from a team as a code owner December 4, 2025 21:05
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 7609877 into main Dec 5, 2025
90 of 92 checks passed
@neilalexander neilalexander deleted the mqtt_restore_retained_msgs branch December 5, 2025 10:28
neilalexander added a commit that referenced this pull request Dec 5, 2025
Includes the following:

- #7581
- #7585
- #7586
- #7565
- #7588
- #7593
- #7589
- #7594
- #7595
- #7596
- #7597
- #7598
- #7600
- #7601
- #7602
- #7604
- #7605
- #7607
- #7609
- #7610
- #7616
- #7614

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Dec 18, 2025
Includes the following:

- #7553
- #7555
- #7579
- #7578
- #7581
- #7585
- #7586
- #7588
- #7593
- #7594
- #7595
- #7596
- #7597
- #7598
- #7601
- #7604
- #7605
- #7610
- #7616
- #7614
- #7622
- #7619
- #7624
- #7625
- #7627
- #7636
- #7637
- #7643
- #7648
- #7634
- #7655
- #7656

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants