Skip to content

Comments

Fix data race in isStreamHealthy#7619

Merged
neilalexander merged 1 commit intomainfrom
maurice/stream-healthy-race
Dec 8, 2025
Merged

Fix data race in isStreamHealthy#7619
neilalexander merged 1 commit intomainfrom
maurice/stream-healthy-race

Conversation

@MauriceVanVeen
Copy link
Member

@MauriceVanVeen MauriceVanVeen commented Dec 5, 2025 

WARNING: DATA RACE
Write at 0x00c0000bd7c8 by goroutine 68843:
  github.com/nats-io/nats-server/v2/server.(*stream).updateWithAdvisory()
      /home/runner/work/nats-server/nats-server/server/stream.go:2494 +0x1d9e

Previous read at 0x00c0000bd7c8 by goroutine 67092:
  github.com/nats-io/nats-server/v2/server.(*jetStream).isStreamHealthy()
      /home/runner/work/nats-server/nats-server/server/jetstream_cluster.go:640 +0x2ae

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
Fix data race in isStreamHealthy
30a5bac 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 5, 2025 13:05
neilalexander
neilalexander approved these changes Dec 5, 2025
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 65bd295 into main Dec 8, 2025
152 of 158 checks passed
@neilalexander neilalexander deleted the maurice/stream-healthy-race branch December 8, 2025 15:26
@neilalexander neilalexander mentioned this pull request Dec 11, 2025
Merged
neilalexander added a commit that referenced this pull request Dec 11, 2025
@neilalexander
Cherry-picks for 2.12.3-RC.3 (#7635)
260042b 
Includes the following:

- #7622
- #7619
- #7624
- #7625
- #7627
- #7630
- #7631
- #7632

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander mentioned this pull request Dec 18, 2025
Merged
neilalexander added a commit that referenced this pull request Dec 18, 2025
@neilalexander
Cherry-picks for 2.11.12-RC.1 (#7669)
34fcec2 
Includes the following:

- #7553
- #7555
- #7579
- #7578
- #7581
- #7585
- #7586
- #7588
- #7593
- #7594
- #7595
- #7596
- #7597
- #7598
- #7601
- #7604
- #7605
- #7610
- #7616
- #7614
- #7622
- #7619
- #7624
- #7625
- #7627
- #7636
- #7637
- #7643
- #7648
- #7634
- #7655
- #7656

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neilalexander neilalexander neilalexander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MauriceVanVeen @neilalexander