Skip to content

Comments

De-flake TestNoRaceStoreReverseWalkWithDeletesPerf#7663

Merged
neilalexander merged 1 commit intomainfrom
maurice/deflake-reverse-walk
Dec 17, 2025
Merged

De-flake TestNoRaceStoreReverseWalkWithDeletesPerf#7663
neilalexander merged 1 commit intomainfrom
maurice/deflake-reverse-walk

Conversation

@MauriceVanVeen
Copy link
Member

The reverse linear scan would expire the cache, which made the optimized LoadPrevMsg seem worse. Now we preload the cache for both cases, to only measure the performance of the search itself.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 17, 2025 13:20
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit f1f8edd into main Dec 17, 2025
68 of 70 checks passed
@neilalexander neilalexander deleted the maurice/deflake-reverse-walk branch December 17, 2025 14:55
neilalexander added a commit that referenced this pull request Jan 6, 2026
Includes the following:

- #7565
- #7589
- #7600
- #7602
- #7609
- #7610
- #7632
- #7649
- #7642
- #7658
- #7659
- #7661
- #7662
- #7663
- #7668
- #7683
- #7685
- #7686
- #7678
- #7691
- #7696
- #7698
- #7699
- #7700

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Jan 6, 2026
Includes the following:

- #7658
- #7659
- #7661
- #7662
- #7663
- #7642
- #7668
- #7683
- #7685
- #7686
- #7678
- #7691
- #7696
- #7697
- #7698
- #7699
- #7700

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants