Skip to content

Comments

[FIXED] R1 mset.lseq desync when exceeding limits#7658

Merged
neilalexander merged 1 commit intomainfrom
maurice/mset-lseq-desync
Dec 17, 2025
Merged

[FIXED] R1 mset.lseq desync when exceeding limits#7658
neilalexander merged 1 commit intomainfrom
maurice/mset-lseq-desync

Conversation

@MauriceVanVeen
Copy link
Member

mset.lseq is incremented for every successful call to processJetStreamMsg that results in storing a message. However, this wasn't fully true. An invalid TTL header or (more commonly) exceeding resource limits would see mset.lseq pre-incremented and not reset after an error. Normally this would not result in an error, but the stream can't scale up cleanly when in this state, resulting in ErrSequenceMismatch.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner December 16, 2025 17:34
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/mset-lseq-desync branch from 9b97d67 to 36ffbc6 Compare December 16, 2025 17:45
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/mset-lseq-desync branch from 36ffbc6 to 549711a Compare December 16, 2025 18:28
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit d19834c into main Dec 17, 2025
69 of 70 checks passed
@neilalexander neilalexander deleted the maurice/mset-lseq-desync branch December 17, 2025 10:30
neilalexander added a commit that referenced this pull request Jan 6, 2026
Includes the following:

- #7565
- #7589
- #7600
- #7602
- #7609
- #7610
- #7632
- #7649
- #7642
- #7658
- #7659
- #7661
- #7662
- #7663
- #7668
- #7683
- #7685
- #7686
- #7678
- #7691
- #7696
- #7698
- #7699
- #7700

Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander added a commit that referenced this pull request Jan 6, 2026
Includes the following:

- #7658
- #7659
- #7661
- #7662
- #7663
- #7642
- #7668
- #7683
- #7685
- #7686
- #7678
- #7691
- #7696
- #7697
- #7698
- #7699
- #7700

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants