Consumer inactive threshold cleanup should stop when consumer stops#7799
Merged
neilalexander merged 1 commit intomainfrom Feb 5, 2026
Merged
Consumer inactive threshold cleanup should stop when consumer stops#7799neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Neil Twigg <neil@nats.io>
wallyqs
pushed a commit
to wallyqs/nats-server
that referenced
this pull request
Feb 5, 2026
This test verifies that when a consumer is stopped while the deleteNotActive goroutine is in its retry loop, the goroutine properly exits via the consumer's quit channel (o.qch). The test creates a clustered consumer with a short InactiveThreshold, waits for it to become inactive (triggering deleteNotActive), and then explicitly deletes the consumer via API. This exercises the new code path that monitors o.qch in the select loop. Relates to PR nats-io#7799 which fixes lingering goroutines when a consumer is deleted by another code path while deleteNotActive is retrying. https://claude.ai/code/session_01LubvjBKycBMMi3kDUiaMYb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids lingering goroutines.
Signed-off-by: Neil Twigg neil@nats.io