[FIXED] Consumer unpin behavior and advisories & added test#7819
Merged
neilalexander merged 1 commit intomainfrom Feb 13, 2026
Merged
[FIXED] Consumer unpin behavior and advisories & added test#7819neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
MauriceVanVeen
force-pushed
the
maurice/pin-fixes
branch
from
d27953c to
ef318a7
Compare
MauriceVanVeen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves/fixes an issue when unpinning as admin would not reset some fields, nor would a new client be able to pick up the next pin without new messages coming in. Similarly the pinned state needs to reset when stepping down to follower, and not send a timeout advisory if the unpin already happened.
Also added a strict test solidifying the behavior around only pinning a client when delivering a message to one.
Signed-off-by: Maurice van Veen github@mauricevanveen.com