[FIXED] Race condition when remapping group#7820
Merged
neilalexander merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
wallyqs
pushed a commit
to wallyqs/nats-server
that referenced
this pull request
Feb 12, 2026
Reviewed the fix for a race condition in processClusterUpdateStream() where removeNode() was called without waiting for the monitor goroutine to fully exit, potentially leaving streams unmonitored after remapping or causing data races during R1 downgrade. https://claude.ai/code/session_01Y8dPryfpBsiWPaJwPssGR8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When remapping the Raft group we need not only remove the current node, we also need to wait for the current monitor goroutine to exit. Otherwise we might open a new monitor goroutine too soon such that it exits as the other is still active before it shuts down.
Signed-off-by: Maurice van Veen github@mauricevanveen.com