[IMPROVED] Include pending msgs/bytes when being unpinned#7815
Merged
neilalexander merged 1 commit intomainfrom Feb 11, 2026
Merged
[IMPROVED] Include pending msgs/bytes when being unpinned#7815neilalexander merged 1 commit intomainfrom
neilalexander merged 1 commit intomainfrom
Conversation
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Contributor
|
@MauriceVanVeen you'll do a ADR update also? |
Member
Author
Maybe I'm overlooking it, but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
o.nextWaiting(..)exposes the pending messages and bytes left in the current pull request, for example with a408 Request Timeoutor409 Message Size Exceeds MaxBytes. This was done for all such errors returned ino.nextWaitingexcept for423 Nats-Wrong-Pin-Id. This PR makes that consistent. Every error returned fromo.nextWaitingcontains the pending counts.Signed-off-by: Maurice van Veen github@mauricevanveen.com