This repository was archived by the owner on Mar 4, 2020. It is now read-only.
feat(Provider): allow to render to multiple documents #1252
Merged
layershifter merged 7 commits intomasterfrom Jul 26, 2019
Merged
feat(Provider): allow to render to multiple documents #1252layershifter merged 7 commits intomasterfrom
layershifter merged 7 commits intomasterfrom
Conversation
This was referenced Apr 23, 2019
layershifter
force-pushed
the
fix/multiple-doc
branch
2 times, most recently
from
cce5b1e to
9c3d746
Compare
Collaborator
Changed dependencies are detected.Changed dependencies in
Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
=======================================
Coverage 73.21% 73.21%
=======================================
Files 822 822
Lines 6194 6194
Branches 1782 1801 +19
=======================================
Hits 4535 4535
Misses 1654 1654
Partials 5 5
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
=======================================
Coverage 70.92% 70.92%
=======================================
Files 860 860
Lines 7148 7148
Branches 2057 2077 +20
=======================================
Hits 5070 5070
Misses 2072 2072
Partials 6 6
Continue to review full report at Codecov.
|
layershifter
force-pushed
the
fix/multiple-doc
branch
from
9c3d746 to
a7fc4e8
Compare
layershifter
force-pushed
the
fix/multiple-doc
branch
2 times, most recently
from
5559fda to
0743b88
Compare
layershifter
force-pushed
the
fix/multiple-doc
branch
from
5bde948 to
eb12ac2
Compare
layershifter
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
layershifter
changed the title
…stardust-ui/react into fix/multiple-doc # Conflicts: # CHANGELOG.md # packages/react/src/components/Provider/Provider.tsx
layershifter
added a commit
that referenced
this pull request
Aug 2, 2019
(cherry picked from commit 25ac574)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1178.
This feature is based on
@stardust-ui/felafork, it uses changes from robinweser/fela#718. Fela has another PR with a bit different approach, but we don't have any ETA for it, robinweser/fela#722.We are going to migrate to Fela once we will get this feature.
Problem
We need to have a prop to specify a
documentwhere styles should be rendered.Implementation
This PR only adds
targetprop that will be passed directly to Fela. Uses single renderer, all existing styles will be initially provided from cache.All handling is done on Fela side, it's described in robinweser/fela#718.