feat(appset): applicationset controller use repo server (#10952)#12714
Merged
alexmt merged 89 commits intoargoproj:masterfrom Apr 28, 2023
Merged
feat(appset): applicationset controller use repo server (#10952)#12714alexmt merged 89 commits intoargoproj:masterfrom
alexmt merged 89 commits intoargoproj:masterfrom
Conversation
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…12515 (argoproj#12621) Signed-off-by: Mayursinh Sarvaiya <marvinduff97@gmail.com> Co-authored-by: Remington Breeze <remington@breeze.software> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
* fix: Procfile Fixing the procfile goreman runs for E2E test startup to be POSIX-shell compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> * Update root Procfile to be POSIX compliant Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> --------- Signed-off-by: Patrick Bardo <76942752+patrickbardo@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
This updates the manifest link directly to the High Availability header in the manifest readme. I chose this over linking to the `ha` folder since it explains the options and links to them. Signed-off-by: Nicholas Morey <nicholas@morey.tech> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…ckerfile` (argoproj#12622) (argoproj#12623) * Pinned container images by digest hashes. Signed-off-by: adamibs <bsadambs@gmail.com> * Update test/container/Dockerfile Co-authored-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> --------- Signed-off-by: adamibs <bsadambs@gmail.com> Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Justin Marquis <34fathombelow@protonmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
* fix: exclude test/fixtures from .dockerignore argoproj#12620 introduced the ignore of the `test/` directory, which had the unintended effect of breaking `make start`. To amend that, add an override for `test/fixture` in order to unbreak `test/container/dockerfile`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: also exclude `test/containers` Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Bumps [dawidd6/action-homebrew-bump-formula](https://github.com/dawidd6/action-homebrew-bump-formula) from 3.8.3 to 3.9.0. - [Release notes](https://github.com/dawidd6/action-homebrew-bump-formula/releases) - [Commits](dawidd6/action-homebrew-bump-formula@02e79d9...e9b43cd) --- updated-dependencies: - dependency-name: dawidd6/action-homebrew-bump-formula dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
* fix: ensure certificate gets updated on reload Fixes argoproj#10707. `GetCertificate` ensures that the most current version of `a.settings.Certificate` is used. It's still a bit of a mystery to me as to why the reloading of the server does not work for this, since it should fulfill the same function. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * fix: remove break from cert changes With 3553ef8, there's no longer any need to break out of the loop. The webhook reloading logic needs another look (since it likely no longer works), but can be handled in another PR. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…#12698) Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: Gergely Czuczy <gergely.czuczy@sap.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…rgoproj#12700) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
* 2.6 addendum for plugin.name Signed-off-by: Raymond Wong <61470342+rwong2888@users.noreply.github.com> * Clearer doc on plugin.name --------- Signed-off-by: Raymond Wong <61470342+rwong2888@users.noreply.github.com> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
rumstead
force-pushed
the
feat/appset-controller-use-repo-server
branch
from
ead4a9e to
72a8b83
Compare
…-controller-use-repo-server
rumstead
commented
Mar 3, 2023
rumstead
commented
Mar 3, 2023
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…-controller-use-repo-server # Conflicts: # reposerver/apiclient/repository.pb.go # reposerver/cache/cache.go
…umstead/argo-cd into feat/appset-controller-use-repo-server
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…-controller-use-repo-server
gdsoumya
requested changes
Apr 26, 2023
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…umstead/argo-cd into feat/appset-controller-use-repo-server
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
…umstead/argo-cd into feat/appset-controller-use-repo-server
gdsoumya
approved these changes
Apr 28, 2023
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
alexmt
approved these changes
Apr 28, 2023
Collaborator
alexmt
left a comment
alexmt
left a comment
There was a problem hiding this comment.
Thank you @rumstead ! Appreciate the review @ishitasequeira and @gdsoumya !
13 tasks
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
…) (argoproj#12714) feat(appset): applicationset controller use repo server (argoproj#10952) (argoproj#12714) Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
6 tasks
3 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
closes #10952 (kinda)
https://github.com/rumstead/argocd-playground/tree/main/manifests/applicationsets - manifests used for testing
Checklist: