[Snyk] Security upgrade next from 14.2.35 to 15.5.10#875
[Snyk] Security upgrade next from 14.2.35 to 15.5.10#875
Conversation
Signed-off-by: AU_gdev_19 <64915515+Dargon789@users.noreply.github.com>
Co-authored-by: TomTom <rtomas@gmail.com> Co-authored-by: Enes <enesozturk.d@gmail.com> Co-authored-by: Derek <alexanderderekrein@gmail.com> Co-authored-by: Sven <38101365+svenvoskamp@users.noreply.github.com> Co-authored-by: tomiir <rocchitomas@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Enes <enesozturk.d@gmail.com>
Co-authored-by: Derek <alexanderderekrein@gmail.com>
… not supported (reown-com#4026) Co-authored-by: tomiir <rocchitomas@gmail.com>
… list (reown-com#4300) Co-authored-by: Derek <alexanderderekrein@gmail.com>
…tworks with auth connector (reown-com#4311)
Co-authored-by: MK <mago.khamidov@gmail.com> Co-authored-by: MK <53529533+magiziz@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
⛔ Snyk checks have failed. 18 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request from Snyk addresses a security vulnerability by upgrading next from version 14.2.35 to 15.5.10. While the dependency update itself is straightforward, this is a major version change and requires careful handling. My review highlights two important follow-up actions: manually updating the pnpm-lock.yaml file which failed to generate, and upgrading the eslint-config-next package for compatibility with Next.js 15. Addressing these points is essential for the stability and consistency of the project. Thorough testing is also recommended to catch any potential breaking changes from the Next.js upgrade.
| "@tanstack/react-query": "5.75.5", | ||
| "@wagmi/core": "2.22.1", | ||
| "next": "14.2.35", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
As noted in the pull request description, the pnpm-lock.yaml file was not updated. This is a critical step that must be completed manually before merging. Without an updated lockfile, this security fix will not be applied consistently across different environments. Please run pnpm install to regenerate the lockfile and commit the result.
| "@tanstack/react-query": "5.75.5", | ||
| "@wagmi/core": "2.22.1", | ||
| "next": "14.2.35", | ||
| "next": "15.5.10", |
There was a problem hiding this comment.
With the major version upgrade of next to v15, the eslint-config-next package should also be updated to maintain compatibility. The current version 14.1.0 is for Next.js 14 and may cause issues with Next.js 15. Please update eslint-config-next to a compatible version, likely 15.5.10.
…duce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
…duce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-NEXT-15104645
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| test('should handle origins and patterns with dots correctly', () => { | ||
| const patternsWithDots = ['https://test\\.example\\.com'] | ||
| const defaultWithDots = ['https://*.another\\.test\\.org'] |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames High test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 19 days ago
In general, to fix incomplete or overly permissive regular expressions for hostnames, every dot that is meant to represent a literal . in the hostname must be escaped as \. in the corresponding regex (or pattern that will become a regex). Only dots that are intentionally acting as regex wildcards should remain unescaped, and those should be used with care in security-sensitive code.
In this specific test, the pattern string 'https://*.another\\.test\\.org' is intended to represent hosts under another.test.org with a wildcard subdomain. To ensure the host portion is treated literally except for the wildcard, the dot between another and test must be escaped as well. Therefore, on line 559 in packages/appkit/tests/utils/HelpersUtil.test.ts, update the string to 'https://*.another\\.test\\.org' → 'https://*\\.another\\.test\\.org' or, more precisely for the specific reported dot, escape the unescaped dot so that the hostname is consistently another\.test\.org. Since we must respect the CodeQL complaint ("unescaped '.' before 'test.org'"), the minimal change is to escape that specific dot, yielding 'https://*.another\\.test\\.org' → 'https://*.another\\.test\\.org' with an added backslash before that dot: 'https://*.another\\.test\\.org' → 'https://*.another\\.test\\.org' becomes 'https://*.another\\.test\\.org' with another\.test\.org internally. In TypeScript, the backslash must itself be escaped inside the string literal, so the fixed value should be 'https://*.another\\.test\\.org' where all hostname dots are written as \\.. No new imports or helper methods are required; only this test pattern string needs to be corrected.
| @@ -556,7 +556,7 @@ | ||
|
|
||
| test('should handle origins and patterns with dots correctly', () => { | ||
| const patternsWithDots = ['https://test\\.example\\.com'] | ||
| const defaultWithDots = ['https://*.another\\.test\\.org'] | ||
| const defaultWithDots = ['https://*\\.another\\.test\\.org'] | ||
| expect( | ||
| WcHelpersUtil.isOriginAllowed('https://test.example.com', patternsWithDots, defaultWithDots) | ||
| ).toBe(true) // Exact match |
10 participants
Snyk has created this PR to fix 1 vulnerabilities in the pnpm dependencies of this project.
Snyk changed the following file(s):
examples/next-wagmi-solana-bitcoin-app-router/package.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-NEXT-15104645
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling