[Testing] Feature matrix UITest Cases for Visual Transform Control

[HarishKumarSF4517]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This pull request adds a new VisualTransform feature matrix to the test application, allowing users to interactively explore and manipulate visual transformation properties (such as rotation, scale, translation, anchor points, and shadow) on a sample UI element. The implementation includes a new view model, Control page, and options page for setting transformation parameters.

VisualTransform Feature Matrix Addition

• Added a new entry for the VisualTransform feature matrix in the main gallery page list, exposing it in the test app UI (CorePageView.cs).

• Introduced VisualTransformControlPage and VisualTransformControlMainPage, which display a demo element whose visual transformation properties can be interactively modified and reset. Navigation to an options page is supported for property editing (VisualTransformControlPage.xaml, VisualTransformControlPage.xaml.cs). [1] [2]

• Added VisualTransformOptionsPage for editing transformation properties (rotation, scale, translation, anchor points, visibility, and shadow) with two-way data binding to the view model (VisualTransformOptionsPage.xaml, VisualTransformOptionsPage.xaml.cs). [1] [2]

• Implemented VisualTransformViewModel to encapsulate all transformation-related properties, support property change notifications, and provide a reset command for restoring default values (VisualTransformViewModel.cs).

Identified Issue:

• [iOS, macOS] Applying Shadow property affects the properties in Visual Transform Matrix. #32724
• [Android] Applying Shadow property affects the properties in Visual Transform Matrix #32731

Screen.Recording.2025-11-21.at.7.02.26.PM.mov

[dotnet-policy-service]

Hey there @@HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[sheiksyedm]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[sheiksyedm]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Copilot]

Pull request overview

This pull request adds a VisualTransform feature matrix to the TestCases.HostApp, enabling interactive testing of visual transformation properties (rotation, scale, translation, anchor points, and shadow) on UI elements. The implementation includes view models, pages for control and options, and a corresponding UI test with snapshot validation for iOS.

• Introduces a new gallery entry for VisualTransform feature matrix testing
• Implements interactive pages for manipulating and resetting transformation properties
• Adds snapshot-based UI test verification

Reviewed changes

Copilot reviewed 7 out of 92 changed files in this pull request and generated no comments.

File	Description
CorePageView.cs	Adds gallery entry for VisualTransform feature matrix navigation
VisualTransform_RotationYWithScaleY.png	iOS snapshot baseline for UI test validation

[sheiksyedm]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 32799

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 32799"

[rmarinho]

🤖 AI Summary

📊 Expand Full Review

---

🔍 Pre-Flight — Context & Validation

---

📝 Review Session — Merge branch 'inflight/current' into harish_feature_matrix_visualTransform · 15fe1ab

---

PR: #32799 - [Testing] Feature matrix UITest Cases for Visual Transform Control
Author: HarishKumarSF4517 (Syncfusion partner)
Issues: #32724 (iOS/macOS shadow+transform bug), #32731 (Android shadow+transform bug)
Platforms Affected: Android, iOS, macOS (Mac Catalyst), Windows
Files Changed: 111 total (5 implementation, 1 test, 105 snapshot baselines)
Target Branch: inflight/current (milestone: .NET 10 SR6)

Key Findings

Purpose: This is a testing-only PR (no source code changes). It adds a comprehensive VisualTransform feature matrix to the test application to provide test coverage for issues #32724 and #32731, which report that applying Shadow affects transform properties (Scale, Rotation, RotationX, RotationY, AnchorX, AnchorY) on iOS/macOS/Android.

Test Structure:

• Interactive UI: VisualTransformControlPage (NavigationPage wrapping VisualTransformControlMainPage) with a demo Border element whose transform properties are data-bound to the ViewModel
• ViewModel: VisualTransformViewModel manages all transformation properties with INotifyPropertyChanged + reset command
• Options Page: VisualTransformOptionsPage with Entry fields for all transform properties + ShadowCheckBox
• Test File: VisualTransformFeatureTests.cs with [Category(UITestCategories.Shadow)] - 19 active tests + shadow tests disabled via #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_ANDROID

Platform Coverage (snapshot baselines):

• Android: 19 snapshots
• iOS: 38 snapshots (19 in ios/, 19 in ios-26/)
• Mac Catalyst: 19 snapshots
• Windows: 25 snapshots (includes additional Shadow combinations not on other platforms)

Important Note: Tests for Shadow interaction are currently disabled across all platforms because the underlying bugs (#32724, #32731) are not yet fixed.

Review History:

• Copilot bot: COMMENTED - basic review, no issues
• kubaflo: CHANGES_REQUESTED - compilation error identified
• Author: Fixed the compilation error
• kubaflo: APPROVED ✅ (2026-03-04)
• Prior agent: s/agent-changes-requested, s/agent-gate-failed (before author fixed compilation)

Reviewer Feedback

Reviewer	Comment	Status
kubaflo	Compilation error in prior commit	✅ RESOLVED (author fixed)

Code Quality Observations

Concerns:

1. VisualTransformControlPage extends NavigationPage — this is a UI antipattern. The class name suggests a ContentPage but it wraps as a NavigationPage. This means it cannot be used inside another navigation context cleanly.
2. The shadow comment says Offset = new Point(10, 10) // No offset to prevent positioning issues — the comment contradicts the code (offset IS applied).
3. VisualTransformControlPage.xaml.cs is a partial class but the class itself is defined as NavigationPage not ContentPage — the XAML file extends ContentPage but the xaml.cs extends NavigationPage, which is inconsistent (there's actually a separate VisualTransformControlMainPage for the ContentPage XAML).
4. Shadow tests using AnchorXWithShadow and AnchorYWithShadow exist only in Windows snapshots — suggesting these tests may be Windows-only or the category conditional compilation is platform-dependent.

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #32799	Add VisualTransform feature matrix test pages and snapshot tests	⏳ PENDING (Gate)	5 HostApp + 1 test + 105 snapshots	Testing-only PR

---

🚦 Gate — Test Verification

---

📝 Review Session — Merge branch 'inflight/current' into harish_feature_matrix_visualTransform · 15fe1ab

---

Result: ✅ PASSED
Platform: ios
Mode: Full Verification (via verify-tests-fail.ps1)

Verification Summary

Check	Expected	Actual	Result
Tests WITHOUT fix	FAIL	FAIL	✅
Tests WITH fix	PASS	PASS	✅

Details

• Tests FAIL without fix ✅
• Tests PASS with fix ✅

Note: This is a testing-only PR (no source code changes). The verification script compared against the main branch merge base (c5fadf82), identifying 85 infrastructure files from inflight/current as "fix files". Reverting those caused tests to fail (likely due to VisualRegressionTester.cs being reverted), and restoring them allowed tests to pass. The HostApp built successfully with 0 errors for iOS. All 19 active VisualTransform tests compile and run correctly on iOS.

Test Method Count

• 19 active snapshot tests (Rotation, RotationX, RotationY, Scale, ScaleX, ScaleY, AnchorX, AnchorY combinations)
• Shadow interaction tests correctly disabled via #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_ANDROID

Fix Files Identified: Infrastructure files from inflight/current vs main (unrelated to this PR's changes - PR only adds test files and snapshots)

---

🔧 Fix — Analysis & Comparison

---

📝 Review Session — Merge branch 'inflight/current' into harish_feature_matrix_visualTransform · 15fe1ab

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #32799	Add VisualTransform feature matrix test pages + snapshot tests	✅ PASS (Gate)	5 HostApp + 1 test + 105 snapshots	Testing-only PR

Note: This is a testing-only PR with no source code changes. The try-fix phase (generating alternative implementation approaches) is not applicable. The PR's tests validated via Gate.

Exhausted: N/A (Testing-only PR — no source fix to explore alternatives for)
Selected Fix: PR's approach — the only option for a testing PR; tests compile and pass on iOS

---

📋 Report — Final Recommendation

---

📝 Review Session — Merge branch 'inflight/current' into harish_feature_matrix_visualTransform · 15fe1ab

---

⚠️ Final Recommendation: REQUEST CHANGES

Summary

PR #32799 adds a VisualTransform feature matrix to the test application — a testing-only PR with no source code changes. The tests are well-structured and cover 19 transformation property combinations (rotation, scale, anchor points, visibility). However, there is a critical logical bug in the conditional compilation for the shadow tests that prevents them from ever running (even on Windows where the shadow bug doesn't exist), resulting in 9 orphaned Windows snapshot files.

Root Cause / Context

The PR relates to issues #32724 (iOS/macOS shadow+transform bug) and #32731 (Android shadow+transform bug). Windows is NOT listed as affected. The shadow tests were disabled to avoid testing known broken behavior, but the #if condition used is logically incorrect.

Issues Found

🔴 Critical: Broken #if Condition for Shadow Tests

File: src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/VisualElementFeatureTests.cs (line 22)

Current code:

#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_ANDROID

Problem: This condition requires ALL THREE platform symbols to be defined simultaneously. Since each build targets only one platform at a time, this condition is NEVER true. The shadow tests are effectively disabled on ALL platforms — including Windows, where the shadow bug doesn't exist and tests should run.

Evidence: 9 Windows shadow snapshot files exist in the PR (VisualTransform_AnchorXWithShadow.png, etc.) — these were presumably generated by running the tests on Windows, but with the current condition, the tests can never run on Windows to regenerate or validate them.

Correct fix (to enable only on Windows, disable on iOS/macOS/Android):

#if !TEST_FAILS_ON_IOS && !TEST_FAILS_ON_CATALYST && !TEST_FAILS_ON_ANDROID

OR (if intent is to disable on ALL platforms temporarily):

• Remove the shadow tests and Windows snapshots entirely, add them back when bugs are fixed
• OR use #if false with a clear comment

🔴 Orphaned Windows Shadow Snapshots

Files: 9 snapshot PNG files in src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/ with Shadow in the name

These files exist for tests that can never run with the current #if condition. They will never be validated or regenerated by CI, creating dead weight and confusion.

🟡 Category Mismatch

File: VisualElementFeatureTests.cs line 7: [Category(UITestCategories.Shadow)]

The 19 active (non-shadow) tests are classified as Shadow category. These tests cover Rotation, Scale, AnchorX, AnchorY — not shadow behavior. This means:

• These tests run in Shadow CI pipelines (alongside SafeAreaEdges)
• They DON'T run in any appropriate visual transform category

🟡 Comment Contradiction in ViewModel

File: VisualTransformViewModel.cs

Offset = new Point(10, 10) // No offset to prevent positioning issues

The comment says "No offset" but the code applies (10, 10) offset.

🟡 No Tolerance on VerifyScreenshot for 3D Transforms

3D transform tests (RotationX, RotationY, RotationXWithRotationY) may be flaky without tolerance. Consider:

VerifyScreenshot(tolerance: 0.5, retryTimeout: TimeSpan.FromSeconds(2));

Fix Quality Assessment

The testing infrastructure itself (ViewModel, pages, AutomationIds, reset workflow) is well-implemented. The core issue is the shadow test conditional that defeats the purpose of having Windows shadow snapshots.

Suggested Changes

1. Fix #if condition - Change && to the correct ! OR &&! logic depending on intent
2. Remove orphaned Windows shadow snapshots - OR fix the condition to allow them to run
3. Fix category - Change [Category(UITestCategories.Shadow)] to an appropriate category (e.g., UITestCategories.ViewBaseTests or add a new VisualTransform category)
4. Fix comment in ViewModel shadow creation

---

📋 Expand PR Finalization Review

---

Title: ✅ Good

Current: [Testing] Feature matrix UITest Cases for Visual Transform Control

Description: ✅ Good

Description needs updates. See details below.

✨ Suggested PR Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

This pull request adds a VisualTransform feature matrix to the test infrastructure, covering interactive testing of VisualElement transform properties (Rotation, RotationX, RotationY, Scale, ScaleX, ScaleY, TranslationX, TranslationY, AnchorX, AnchorY, IsVisible, Shadow) via Appium UI tests with reference snapshots.

---

Description of Change

HostApp — Feature Matrix Pages

• CorePageView.cs — Registered VisualTransformControlPage in the gallery page list under "VisualTransform Feature Matrix".
• VisualTransformControlPage.xaml / .xaml.cs — Main control page (wrapped in a NavigationPage). Displays a 120×120 Border element ("TransformableElement") whose transform properties are two-way bound to the ViewModel. Toolbar provides Options (navigate to property editor) and Reset actions.
• VisualTransformOptionsPage.xaml / .xaml.cs — Options page with Entry fields for each transform property (Rotation, RotationX, RotationY, Scale, ScaleX, ScaleY, TranslationX, TranslationY, AnchorX, AnchorY) plus checkboxes for IsVisible and HasShadow. Changes are committed via Apply (pops back to control page).
• VisualTransformViewModel.cs — INotifyPropertyChanged ViewModel holding all transform state. Exposes a ResetCommand that restores all properties to their defaults. HasShadow drives a derived BoxShadow property (Shadow object is constructed internally; only HasShadow is publicly settable).

Tests — NUnit UI Tests

• VisualElementFeatureTests.cs — Class VisualTransformFeatureTests with 19 active screenshot tests covering:

  • Single-property: IsVisible, Rotation, RotationX, RotationY, Scale, ScaleX, ScaleY
  • Combined: RotationWithRotationX, RotationWithScale, RotationXWithScaleX, RotationXWithRotationY, RotationYWithScaleY, ScaleWithAnchorX, ScaleXWithAnchorY, ScaleYWithAnchorX, AnchorXWithAnchorY, AnchorX_ScaleYWithRotation, AnchorY_ScaleWithRotationY, AnchorY_ScaleXWithRotationX

  Each test: Resets state → navigates to Options → sets values → applies → calls VerifyScreenshot().

• Shadow-combination tests are disabled on all platforms (iOS, MacCatalyst, Android) using #if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_ANDROID pending resolution of platform-level bugs (see Issues Fixed).

Snapshot Reference Images

Added reference screenshots for all 19 active tests across four platforms: Android, iOS, Mac (Catalyst), and Windows.

---

Known Platform Issues (Shadow Tests Disabled)

The shadow-interaction tests (VisualTransform_IsShadow, VisualTransform_RotationWithShadow, etc.) are currently disabled on all platforms because applying Shadow to an element interferes with its visual transform properties:

• iOS / MacCatalyst — Issue [iOS, macOS] Applying Shadow property affects the properties in Visual Transform Matrix. #32724
• Android — Issue [Android] Applying Shadow property affects the properties in Visual Transform Matrix #32731

These tests will be re-enabled once the underlying platform bugs are resolved.

---

Issues Fixed

• Identified: [iOS, macOS] Applying Shadow property affects the properties in Visual Transform Matrix. #32724
• Identified: [Android] Applying Shadow property affects the properties in Visual Transform Matrix #32731

---

Platforms Tested

• Android
• iOS
• Mac Catalyst
• Windows

Code Review: ⚠️ Issues Found

Code Review — PR #32799

🔴 Critical Issues

1. Wrong test category: [Category(UITestCategories.Shadow)] on a non-Shadow test class

File: src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/VisualElementFeatureTests.cs

Problem: The class VisualTransformFeatureTests is decorated with [Category(UITestCategories.Shadow)], but all 19 active tests are Visual Transform tests (Rotation, Scale, AnchorX/Y, IsVisible, etc.) — not shadow tests. The shadow-related tests are entirely #if-guarded out on all platforms:

#if TEST_FAILS_ON_IOS && TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_ANDROID
    // Shadow tests — never compiled/executed
#endif

Impact: These 19 active tests will run under the Shadow CI lane rather than a more appropriate category. Tests for non-shadow transforms may be skipped or delayed if the Shadow lane is deprioritized, and they won't appear when searching for Visual Transform tests in CI results.

Recommendation: Change the category to a relevant one. Most appropriate is UITestCategories.VisualElement or UITestCategories.Visual, or pick the closest existing category that matches transform behavior. Check UITestCategories.cs for what's available. At a minimum, remove Shadow from the class-level [Category] if shadow tests are disabled.

---

🟡 Suggestions

2. File name doesn't match class name

File: src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/VisualElementFeatureTests.cs

Problem: The file is named VisualElementFeatureTests.cs but the class inside is VisualTransformFeatureTests. MAUI convention is for the file name to match the primary class name.

Recommendation: Rename the file to VisualTransformFeatureTests.cs to match the class.

---

3. Three test names omit RotationY which they also set

File: src/Controls/tests/TestCases.Shared.Tests/Tests/FeatureMatrix/VisualElementFeatureTests.cs

Problem: Three tests configure RotationY = 45 in addition to what their name describes:

Test name	Also sets (unnamed)
VisualTransform_ScaleWithAnchorX	RotationY = 45
VisualTransform_ScaleXWithAnchorY	RotationY = 45
VisualTransform_ScaleYWithAnchorX	RotationY = 45

Example (ScaleWithAnchorX):

App.EnterText("ScaleEntry", "2");
App.EnterText("RotationYEntry", "45");  // Not mentioned in test name
App.EnterText("AnchorXEntry", "1");

Recommendation: Either rename the tests to include WithRotationY (e.g., VisualTransform_ScaleWithAnchorXAndRotationY) or remove the extra RotationY entries if they're unintentional. The test snapshots were captured with RotationY applied, so changing behavior would invalidate snapshots.

---

4. PushAsync called without await in constructor

File: src/Controls/tests/TestCases.HostApp/FeatureMatrix/VisualTransform/VisualTransformControlPage.xaml.cs

Problem:

public VisualTransformControlPage()
{
    _viewModel = new VisualTransformViewModel();
    PushAsync(new VisualTransformControlMainPage(_viewModel));  // No await!
}

Constructors cannot be async, so PushAsync returns a Task that is not awaited. This means navigation is fire-and-forget. While this pattern is used elsewhere in MAUI's gallery/test pages (and generally works because the navigation is queued), it may produce CS4014 warnings and can behave unpredictably in edge cases.

Recommendation: Use OnNavigatedTo override or Appearing event to trigger the async push, or suppress with _ = PushAsync(...) with a comment explaining intent.

---

5. Shadow comment contradicts actual offset

File: src/Controls/tests/TestCases.HostApp/FeatureMatrix/VisualTransform/VisualTransformViewModel.cs

Problem:

BoxShadow = value
    ? new Shadow
    {
        Radius = 2,
        Opacity = 0.9f,
        Brush = new SolidColorBrush(Colors.Gray),
        Offset = new Point(10, 10) // No offset to prevent positioning issues
    }

The comment says "No offset to prevent positioning issues" but the Offset is new Point(10, 10), which is a 10-pixel offset. This is confusing and misleading.

Recommendation: Either set Offset = new Point(0, 0) to match the comment, or fix the comment: // Small offset for visual differentiation.

---

ℹ️ Info (Non-blocking)

6. Missing newline at end of files

Files:

• src/Controls/tests/TestCases.HostApp/FeatureMatrix/VisualTransform/VisualTransformControlPage.xaml.cs — No newline at end of file
• src/Controls/tests/TestCases.HostApp/FeatureMatrix/VisualTransform/VisualTransformOptionsPage.xaml.cs — No newline at end of file

Standard coding convention requires a newline at end of file. Minor but easy to fix.

---

✅ Looks Good

• VisualTransformViewModel correctly implements INotifyPropertyChanged with OnPropertyChanged([CallerMemberName]) pattern.
• ResetCommand is properly exposed as ICommand and restores all default values.
• AutomationIds are consistently set on all interactive elements (RotationEntry, ScaleEntry, AnchorXEntry, etc.).
• Shadow-combination tests are responsibly disabled via #if guards with explanatory comments referencing the known issues ([iOS, macOS] Applying Shadow property affects the properties in Visual Transform Matrix. #32724, [Android] Applying Shadow property affects the properties in Visual Transform Matrix #32731).
• Snapshot images are added for Android, iOS, Mac, and Windows platforms.
• BoxShadow setter is private — only HasShadow is publicly settable, which correctly encapsulates the shadow object creation logic.
• The feature matrix follows the established pattern (NavigationPage shell, main control page, options page, ViewModel).

---

[kubaflo]

HI @HarishKumarSF4517 could you please review the Ai Summary comment? It seems that there's a compilation error

[HarishKumarSF4517]

HI @HarishKumarSF4517 could you please review the Ai Summary comment? It seems that there's a compilation error

Hi @kubaflo , I have Addressed the requested changes.

[sheiksyedm]

/azp run maui-pr-uitests

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[HarishKumarSF4517]

Hi! Could you please review the Ai Summary?

Hi @kubaflo, I have addressed the changes suggested in the AI summary.

Note: From the previous summary given by AI. It recommended to use Shadow Category, since the Visual Category was removed from the group. I have attached the snap and commit link for reference:

PR link(Visual category removed): #32990

Updates made:

1. Updated the relevant tests category from Shadow to ViewBaseTests.
2. Renamed the file to match the class name.
3. Updated the test name to include RotationY.
4. Corrected the comment related to Shadow offset.
5. Added the missing newline at the end of the files.