Skip to content

[iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to ToolbarItems#34085

Merged
kubaflo merged 5 commits intodotnet:inflight/currentfrom
SyedAbdulAzeemSF4852:fix-ios26-toolbaritem-color
Mar 3, 2026
Merged

[iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to ToolbarItems#34085
kubaflo merged 5 commits intodotnet:inflight/currentfrom
SyedAbdulAzeemSF4852:fix-ios26-toolbaritem-color

Conversation

@SyedAbdulAzeemSF4852
Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

  • On iOS 26, setting Shell.ForegroundColor (either at the Shell level or Page level) no longer applies the specified color to ToolbarItems.
  • The toolbar items remain in the default system tint color instead of respecting the configured foreground color.

Root Cause

  • On iOS 26, Apple's LiquidGlass redesign changed how UINavigationBar.TintColor propagates to bar button items — it is no longer automatically inherited.

Description of Change

  • Added UpdateRightBarButtonItemTintColors() method in ShellPageRendererTracker.cs to explicitly set the TintColor of right bar button items to the Shell's foreground color for iOS 26+ and Mac Catalyst 26+. This ensures toolbar items correctly reflect the intended color.
  • Updated property change handlers (HandleShellPropertyChanged, OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when relevant properties change, guaranteeing color updates are applied when needed.

Issues Fixed

Fixes #34083

Validated the behaviour in the following platforms

  • Windows
  • Android
  • iOS
  • Mac

Output

Before After

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 17, 2026
@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 17, 2026
@sheiksyedm sheiksyedm marked this pull request as ready for review February 18, 2026 11:15
Copilot AI review requested due to automatic review settings February 18, 2026 11:15
@sheiksyedm
Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests , maui-pr-devicetests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes an iOS 26-specific issue where Shell.ForegroundColor is not applied to toolbar items due to Apple's LiquidGlass redesign changes. In iOS 26+, UINavigationBar.TintColor no longer automatically propagates to bar button items, requiring explicit TintColor setting on each item.

Changes:

  • Added UpdateRightBarButtonItemTintColors() method to explicitly set TintColor on right bar button items for iOS 26+ and MacCatalyst 26+
  • Updated property change handlers (HandleShellPropertyChanged, OnPagePropertyChanged) to call the new method when ForegroundColor changes
  • Added UI test (Issue34083) with screenshot verification to validate the fix

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ShellPageRendererTracker.cs Added iOS 26+ workaround to explicitly set TintColor on right bar button items when Shell.ForegroundColor changes
Issue34083.cs (HostApp) Test page demonstrating Shell with ForegroundColor and toolbar item
Issue34083.cs (Tests) UI test with screenshot verification for toolbar item color
VerifyShellForegroundColorIsAppliedToToolbarItems.png (ios) Baseline screenshot for iOS < 26
VerifyShellForegroundColorIsAppliedToToolbarItems.png (ios-26) Baseline screenshot for iOS 26+
Comments suppressed due to low confidence (1)

src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs:612

  • The fix only applies TintColor to right bar button items (toolbar items), but the left bar button item (back button/flyout icon) may also be affected by the iOS 26 LiquidGlass change. The UpdateLeftToolbarItems method creates a UIBarButtonItem at line 575-576, but its TintColor is not explicitly set for iOS 26+.

Consider also updating the left bar button item's TintColor in UpdateLeftToolbarItems when iOS 26+ is detected, similar to how UpdateRightBarButtonItemTintColors handles right bar button items. The left bar button item is set in the callback at lines 575-576, so you would need to apply the TintColor there:

NavigationItem.LeftBarButtonItem =
    new UIBarButtonItem(icon, UIBarButtonItemStyle.Plain, (s, e) => LeftBarButtonItemHandler(ViewController, IsRootPage)) { Enabled = enabled };

// Add for iOS 26+
if (OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26))
{
    var foregroundColor = _context?.Shell?.CurrentPage?.GetValue(Shell.ForegroundColorProperty) ??
                        _context?.Shell?.GetValue(Shell.ForegroundColorProperty);
    if (foregroundColor is Graphics.Color shellForegroundColor)
    {
        NavigationItem.LeftBarButtonItem.TintColor = shellForegroundColor.ToPlatform();
    }
}
		void UpdateLeftToolbarItems()
		{
			var shell = _context?.Shell;
			var mauiContext = MauiContext;

			if (shell is null || NavigationItem is null || mauiContext is null)
			{
				return;
			}

			var behavior = BackButtonBehavior;

			var image = behavior.GetPropertyIfSet<ImageSource?>(BackButtonBehavior.IconOverrideProperty, null);
			var enabled = behavior.GetPropertyIfSet(BackButtonBehavior.IsEnabledProperty, true);
			var text = behavior.GetPropertyIfSet<string?>(BackButtonBehavior.TextOverrideProperty, null);
			var command = behavior.GetPropertyIfSet<object?>(BackButtonBehavior.CommandProperty, null);
			var backButtonVisible = behavior.GetPropertyIfSet<bool>(BackButtonBehavior.IsVisibleProperty, true);

			if (String.IsNullOrWhiteSpace(text) && image == null)
			{
				//Add the FlyoutIcon only if the FlyoutBehavior is Flyout
				if (_flyoutBehavior == FlyoutBehavior.Flyout)
				{
					image = shell.FlyoutIcon;
				}
			}

			if (!IsRootPage)
			{
				NavigationItem.HidesBackButton = !backButtonVisible;
				image = backButtonVisible ? image : null;
			}

			image.LoadImage(mauiContext, result =>
			{
				if (ViewController is null)
					return;

				UIImage? icon = null;

				if (image is not null)
				{
					icon = result?.Value;

					var foregroundColor = _context?.Shell.CurrentPage?.GetValue(Shell.ForegroundColorProperty) ??
					_context?.Shell.GetValue(Shell.ForegroundColorProperty);

					if (foregroundColor is null)
					{
						icon = icon?.ImageWithRenderingMode(UIImageRenderingMode.AlwaysOriginal);
					}

					var originalImageSize = icon?.Size ?? CGSize.Empty;

					// The largest height you can use for navigation bar icons in iOS.
					// Per Apple's Human Interface Guidelines, the navigation bar height is 44 points,
					// so using the full height ensures maximum visual clarity and maintains consistency
					// with iOS design standards. This allows icons to utilize the entire available
					// vertical space within the navigation bar container.
					var defaultIconHeight = 44f;
					var buffer = 0.1;
					// We only check height because the navigation bar constrains vertical space (44pt height),
					// but allows horizontal flexibility. Width can vary based on icon design and content,
					// while height must fit within the fixed navigation bar bounds to avoid clipping.

					// if the image is bigger than the default available size, resize it

					if (icon is not null && originalImageSize.Height - defaultIconHeight > buffer)
					{
						if (image is not FontImageSource fontImageSource || !fontImageSource.IsSet(FontImageSource.SizeProperty))
						{
							icon = icon.ResizeImageSource(originalImageSize.Width, defaultIconHeight, originalImageSize);
						}
					}
				}
				else if (String.IsNullOrWhiteSpace(text) && IsRootPage && _flyoutBehavior == FlyoutBehavior.Flyout)
				{
					icon = DrawHamburger();
				}

				if (icon != null)
				{
					NavigationItem.LeftBarButtonItem =
						new UIBarButtonItem(icon, UIBarButtonItemStyle.Plain, (s, e) => LeftBarButtonItemHandler(ViewController, IsRootPage)) { Enabled = enabled };
				}
				else
				{
					NavigationItem.LeftBarButtonItem = null;
					UpdateBackButtonTitle();
				}

				if (NavigationItem.LeftBarButtonItem != null)
				{
					if (String.IsNullOrWhiteSpace(image?.AutomationId))
					{
						if (IsRootPage)
						{
							NavigationItem.LeftBarButtonItem.AccessibilityIdentifier = "OK";
							NavigationItem.LeftBarButtonItem.AccessibilityLabel = "Menu";
						}
						else
							NavigationItem.LeftBarButtonItem.AccessibilityIdentifier = "Back";
					}
					else
					{
						NavigationItem.LeftBarButtonItem.AccessibilityIdentifier = image.AutomationId;
					}

					if (image != null)
					{
#pragma warning disable CS0618 // Type or member is obsolete
						NavigationItem.LeftBarButtonItem.SetAccessibilityHint(image);
						NavigationItem.LeftBarButtonItem.SetAccessibilityLabel(image);
#pragma warning restore CS0618 // Type or member is obsolete
					}
				}
			});

			UpdateBackButtonTitle();
		}

Comment on lines +470 to +488
if (!(OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26)))
{
return;
}

if (NavigationItem?.RightBarButtonItems is not { Length: > 0 } rightItems)
{
return;
}

var foregroundColor = _context?.Shell?.CurrentPage?.GetValue(Shell.ForegroundColorProperty) ??
_context?.Shell?.GetValue(Shell.ForegroundColorProperty);

if (foregroundColor is Graphics.Color shellForegroundColor)
{
var platformColor = shellForegroundColor.ToPlatform();
foreach (var item in rightItems)
{
item.TintColor = platformColor;
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version check logic is inverted. The condition !(OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26)) returns early when the version is LESS than 26, meaning the TintColor update only happens on iOS 26+. This is correct based on the PR description.

However, consider using a positive condition for better readability:

if (OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26))
{
    // Update TintColor for iOS 26+ only
    if (NavigationItem?.RightBarButtonItems is not { Length: > 0 } rightItems)
    {
        return;
    }
    // ... rest of the logic
}

This makes it immediately clear that the code executes FOR iOS 26+, not AGAINST it.

Suggested change
if (!(OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26)))
{
return;
}
if (NavigationItem?.RightBarButtonItems is not { Length: > 0 } rightItems)
{
return;
}
var foregroundColor = _context?.Shell?.CurrentPage?.GetValue(Shell.ForegroundColorProperty) ??
_context?.Shell?.GetValue(Shell.ForegroundColorProperty);
if (foregroundColor is Graphics.Color shellForegroundColor)
{
var platformColor = shellForegroundColor.ToPlatform();
foreach (var item in rightItems)
{
item.TintColor = platformColor;
if (OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26))
{
if (NavigationItem?.RightBarButtonItems is not { Length: > 0 } rightItems)
{
return;
}
var foregroundColor = _context?.Shell?.CurrentPage?.GetValue(Shell.ForegroundColorProperty) ??
_context?.Shell?.GetValue(Shell.ForegroundColorProperty);
if (foregroundColor is Graphics.Color shellForegroundColor)
{
var platformColor = shellForegroundColor.ToPlatform();
foreach (var item in rightItems)
{
item.TintColor = platformColor;
}

Copilot uses AI. Check for mistakes.
@@ -0,0 +1,24 @@
#if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS // Android Issue Link: https://github.com/dotnet/maui/issues/24676, Windows Issue Link: https://github.com/dotnet/maui/issues/34071
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test includes a preprocessor directive TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS which disables the test on Android and Windows. The comment references two separate issues for Android and Windows failures.

However, this test should NOT fail on these platforms - it's testing iOS-specific behavior (the test page is marked PlatformAffected.iOS). The test should simply not run on Android/Windows.

Consider using a cleaner approach:

  • Remove the TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS directive entirely
  • The test framework should automatically skip tests for platforms not affected based on the PlatformAffected.iOS attribute in the Issue attribute
  • If platform-specific test execution is needed, use #if IOS || MACCATALYST instead

Copilot uses AI. Check for mistakes.
@rmarinho
Copy link
Copy Markdown
Member

rmarinho commented Feb 18, 2026

🤖 AI Summary

📊 Expand Full Review
🔍 Pre-Flight — Context & Validation
📝 Review SessionUpdate: handle TintColor reset and add baseline snapshost for Mac · 83d9524

Issue: #34083 - [iOS26] Shell.ForegroundColor is not applied to ToolbarItems
PR: #34085 - [iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to ToolbarItems
Author: SyedAbdulAzeemSF4852 (Syncfusion partner contributor)
Platforms Affected: iOS 26, MacCatalyst 26 (iOS/Mac-specific behavior change due to Apple LiquidGlass redesign)
Labels: platform/ios, area-controls-toolbar, version/iOS-26, partner/syncfusion, community

Prior Agent Reviews

Two prior agent reviews were conducted, both with Gate FAILED due to environment limitation: no iOS 26 simulator was available. This review has iOS 26.1 simulators available and can properly verify the fix.

Issue Summary

On iOS 26, Apple's LiquidGlass redesign changed how UINavigationBar.TintColor propagates to bar button it is no longer automatically inherited by UIBarButtonItem instances. As a result, Shell.ForegroundColor set at the Shell or Page level no longer applies to ToolbarItems on iOS 26+. This was validated by Syncfusion/Ahamed-Ali as reproducible on iOS 26 with MAUI 10.0.0 and 10.0.40.items

Fix Description

Added UpdateRightBarButtonItemTintColors() method in ShellPageRendererTracker.cs that:

  • Version-guarded to iOS 26+ and MacCatalyst 26+ only
  • Explicitly iterates over NavigationItem.RightBarButtonItems and sets TintColor on each item
  • Reads ForegroundColor from CurrentPage first, then falls back to Shell level
  • Sets TintColor = null (system default) when ForegroundColor is cleared (null reset handled correctly via ternary pattern)
  • Called from UpdateToolbarItems(), HandleShellPropertyChanged, and OnPagePropertyChanged

Files Changed

Fix files:

  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs (+32 lines)

Test files:

  • src/Controls/tests/TestCases.HostApp/Issues/Issue34083.cs (+32 lines, new)
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue34083.cs (+24 lines, new)

Snapshot images:

  • src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyShellForegroundColorIsAppliedToToolbarItems.png
  • src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/VerifyShellForegroundColorIsAppliedToToolbarItems.png
  • src/Controls/tests/TestCases.Mac.Tests/snapshots/mac/VerifyShellForegroundColorIsAppliedToToolbarItems.png

Reviewer Feedback (Copilot)

File:Line Reviewer Says Status
ShellPageRendererTracker.cs:488 Use positive condition instead of negated early return for readability Style only, functionally correct
Issue34083.cs:1 TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS - suggest removing (PlatformAffected.iOS handles it) Minor - standard codebase pattern

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #34085 Explicitly set TintColor on right bar button items for iOS 26+ in UpdateRightBarButtonItemTintColors(); handles null reset when ForegroundColor PENDING (Gate) ShellPageRendererTracker.cs (+32) Original PR, updated after prior reviews cleared

🚦 Gate — Test Verification
📝 Review SessionUpdate: handle TintColor reset and add baseline snapshost for Mac · 83d9524

Result PASSED:
Platform: ios (iOS 26.1 - iPhone 17 Pro simulator)
Mode: Full Verification

Test Results

Check Expected Actual Result
Tests WITHOUT fix FAIL FAIL
Tests WITH fix PASS PASS

Analysis

The Gate verification PASSED on iOS 26.1 (iPhone 17 Pro simulator). Previous reviews failed because no iOS 26 simulator was available. This environment has iOS 26.1 available which correctly exercises the version-guarded fix.

  • Tests FAIL without the fix (bug is present): TintColor not applied to toolbar items on iOS 26
  • Tests PASS with the fix (bug is fixed): TintColor explicitly set via UpdateRightBarButtonItemTintColors()

Note: Auto-detected fix files included some environment-specific files (ci-copilot.yml, provision.yml, VisualRegressionTester.cs) that are modified locally but not part of this PR's diff. The key fix file ShellPageRendererTracker.cs was correctly reverted and restored for the two-run verification.

Conclusion

Gate PASSED - Tests correctly detect the iOS 26 TintColor regression and validate the fix.


🔧 Fix — Analysis & Comparison
📝 Review SessionUpdate: handle TintColor reset and add baseline snapshost for Mac · 83d9524

Phase 3: Try-Fix Results

Selected Fix: PR's own UpdateRightBarButtonItemTintColors() approach is the best implementation.

Exhausted: 5 attempts run (1 blocked, 1 pass alternative found but inferior, 2 fail, 1 no-response).Yes

Summary

Attempt Model Approach Result
2 claude-opus-4.6 Rebuild with Inline Tinting PASS (but inferior to PR's fix)
3 gpt-5.2 UIAppearance FAIL (snapshot mismatch) Proxy
4 gpt-5.3-codex In-constructor tinting with FAIL (compile error) rebuild
5 gemini-3-pro-preview (no response from model)
Cross-Pollination Round: No clearly superior new approaches suggested.

Infrastructure Note

iOS 26 snapshot tests require an iPhone 11 Pro simulator (1124x2286px). The default iOS 26 simulators are iPhone 17 Pro (wrong resolution). A custom simulator was created: xcrun simctl create "iPhone 11 Pro (iOS 26)" com.apple.CoreSimulator.SimDeviceType.iPhone-11-Pro com.apple.CoreSimulator.SimRuntime.iOS-26-0.

Best Alternative: Attempt 2 (Rebuild with Inline Tinting)

Attempt 2 found a passing alternative, but it is inferior to the PR's fix:

Aspect PR's Fix Attempt 2
Null reset when ForegroundColor cleared No Yes
Triggers full toolbar rebuild on change No (minimal) Yes (full rebuild)
Code clarity Named method Inline logic
Design quality Better Acceptable

Conclusion

The PR's UpdateRightBarButtonItemTintColors() approach is the best implementation among all alternatives tested. The only passing alternative (Attempt 2) lacks null-reset support and triggers unnecessary rebuilds.


📋 Report — Final Recommendation
📝 Review SessionUpdate: handle TintColor reset and add baseline snapshost for Mac · 83d9524

Phase 4: Report

PR Finalize

Title Assessment

Current: [iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to ToolbarItems

** Platform prefix present, describes the behavior being fixed, concise.Good**

Minor suggestion: standardize casing to [iOS/Mac Catalyst 26] (current uses Mac Catalyst, which is correct).

Description Assessment

** Keep As-Is**Good

The description is well-structured with:

  • NOTE block at the top
  • Root cause section (LiquidGlass TintColor change)
  • Description of change (what UpdateRightBarButtonItemTintColors() does)
  • Issues Fixed with link
  • Platform validation checkboxes (, )Mac iOS
  • Before/After screenshots

Only recommended addition: A "What NOT to do" note that UIAppearance proxy approaches fail for this scenario, to guide future agents.


Code Review Findings

Negated compound condition:

if (!(OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26)))
{
    return;
}

Copilot flagged this. A positive condition is more readable:

if (!OperatingSystem.IsIOSVersionAtLeast(26) && !OperatingSystem.IsMacCatalystVersionAtLeast(26))
{
    return;
}

Both are functionally identical (De Morgan's law). This is a cosmetic preference, not a bug.

Positive Observations

  • Correct null foregroundColor resolves from page or shell level (consistent with left bar button logic)handling
  • Proper null sets TintColor = null when ForegroundColor is cleared, which is critical for correctnessreset
  • Version guard prevents behavior on iOS < 26 where TintColor propagation worked automatically
  • Called from all three necessary locations: UpdateToolbarItems(), HandleShellPropertyChanged(), OnPagePropertyChanged()
  • #if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS guard follows established codebase pattern
  • Snapshot baselines provided for both iOS (18.x) and iOS 26

Design Comparison

The PR's approach is better than the one alternative that passed testing (Attempt 2):

Aspect PR's Fix Best Alternative (Attempt 2)
Null reset when ForegroundColor cleared No Yes
Unnecessary full toolbar rebuild on color change No Yes
Readability Named method Inline

Overall Recommendation

APPROVE

Gate: Tests verified to fail without fix and pass with fix.PASSED

Try-Fix: 5 attempts run across multiple models:

  • 1 alternative passed (Attempt 2) but is inferior to the PR's approach
  • PR's design is cleaner and more correct (handles null reset, minimal updates)

Code quality: Good. One minor style issue (negated condition) but functionally correct.

Confidence: The fix correctly addresses the iOS 26 LiquidGlass behavior change. The approach is minimal, targeted, and consistent with how left bar button items were previously fixed (PR #32997).HIGH


📋 Expand PR Finalization Review
Title: ✅ Good

Current: [iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to ToolbarItems

Description: ✅ Good

Description needs updates. See details below.

✨ Suggested PR Description

Recommended PR Description — PR #34085

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

  • On iOS 26 / Mac Catalyst 26, setting Shell.ForegroundColor (either at the Shell level or Page level) no longer applies the specified color to ToolbarItems.
  • The toolbar items remain in the default system tint color instead of respecting the configured foreground color.

Root Cause

On iOS 26, Apple's LiquidGlass redesign changed how UINavigationBar.TintColor propagates to bar button items — it is no longer automatically inherited by UIBarButtonItems placed in the navigation bar.

Description of Change

  • Added UpdateRightBarButtonItemTintColors() in ShellPageRendererTracker.cs to explicitly set TintColor on each right bar button item to the Shell's foreground color when running on iOS 26+ or Mac Catalyst 26+.
  • Updated HandleShellPropertyChanged and OnPagePropertyChanged to call UpdateRightBarButtonItemTintColors() when Shell.ForegroundColorProperty changes, ensuring live property updates are applied.
  • Updated UpdateToolbarItems() to call UpdateRightBarButtonItemTintColors() after setting right bar button items, ensuring color is applied when toolbar items are first constructed.

Issues Fixed

Fixes #34083

Validated the behaviour in the following platforms

  • Windows
  • Android
  • iOS
  • Mac

Output

Before After
Code Review: ✅ Passed

Code Review — PR #34085

File reviewed: src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Test files reviewed: TestCases.HostApp/Issues/Issue34083.cs, TestCases.Shared.Tests/Tests/Issues/Issue34083.cs


🟡 Suggestions

1. PlatformAffected.iOS in HostApp [Issue] attribute should include Mac Catalyst

File: src/Controls/tests/TestCases.HostApp/Issues/Issue34083.cs

Current:

[Issue(IssueTracker.Github, 34083, "Toolbar Items Do Not Reflect Shell ForegroundColor", PlatformAffected.iOS)]

Problem: The fix applies to both iOS 26 and Mac Catalyst 26 (the code uses OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26)), and the PR title includes Mac Catalyst. The [Issue] attribute should reflect both affected platforms.

Suggested fix:

[Issue(IssueTracker.Github, 34083, "Toolbar Items Do Not Reflect Shell ForegroundColor", PlatformAffected.iOS | PlatformAffected.Mac)]

2. UpdateRightBarButtonItemTintColors() is not protected virtual

File: src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs

Current:

void UpdateRightBarButtonItemTintColors()
{
    // ...
}

Problem: The surrounding methods that call this (HandleShellPropertyChanged, OnPagePropertyChanged, UpdateToolbarItems) are all protected virtual, meaning subclasses can override them. If a subclass overrides UpdateToolbarItems and doesn't call base.UpdateToolbarItems(), the tint colors won't be applied. Additionally, if a subclass needs to customize the tint-color-application behavior, it cannot without overriding the calling methods.

Consideration: This is the same pattern used for UpdateLeftToolbarItems(), which is also private — so this is consistent with existing style. If consistency is the priority, the current approach is acceptable. If extensibility is important, mark it protected virtual.


✅ Looks Good

  • Version guard is correct: OperatingSystem.IsIOSVersionAtLeast(26) || OperatingSystem.IsMacCatalystVersionAtLeast(26) is the proper API for OS version checks in .NET MAUI.
  • Null TintColor handling: When foregroundColor is null (not set), platformColor is null, and setting item.TintColor = null correctly restores the default system tint. This is intentional and correct.
  • Property lookup priority: The method checks CurrentPage foreground color first, then falls back to Shell-level, which correctly mirrors how the framework resolves inherited values.
  • Call sites are complete: All three relevant entry points call the new method — initial construction (UpdateToolbarItems), Shell-level property change (HandleShellPropertyChanged), and page-level property change (OnPagePropertyChanged).
  • Tests provided: UI test with screenshot validation is included for both iOS (regular) and iOS 26 snapshots, and Mac Catalyst. The test is correctly gated with #if TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_WINDOWS.
  • No breaking changes: The fix is version-gated to iOS/Mac Catalyst 26+ and has no effect on older OS versions.

@rmarinho rmarinho added s/agent-changes-requested AI agent recommends changes - found a better alternative or issues s/agent-gate-failed AI could not verify tests catch the bug s/agent-fix-lose Author adopted the agent's fix and it turned out to be bad s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Feb 18, 2026
@kubaflo kubaflo added s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates and removed s/agent-fix-lose Author adopted the agent's fix and it turned out to be bad labels Feb 20, 2026
@SyedAbdulAzeemSF4852 SyedAbdulAzeemSF4852 changed the title [iOS 26] Fix for Shell ForegroundColor not applied to ToolbarItems [iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to ToolbarItems Feb 24, 2026
@SyedAbdulAzeemSF4852
Copy link
Copy Markdown
Contributor Author

Addressed concerns raised in the AI summary.

@kubaflo kubaflo added s/agent-review-incomplete AI agent could not complete all phases (blocker, timeout, error) and removed s/agent-changes-requested AI agent recommends changes - found a better alternative or issues labels Mar 3, 2026
@kubaflo kubaflo changed the base branch from main to inflight/current March 3, 2026 23:28
@kubaflo kubaflo added the s/agent-suggestions-implemented Maintainer applies when PR author adopts agent's recommendation label Mar 3, 2026
@kubaflo kubaflo merged commit 9b1b29a into dotnet:inflight/current Mar 3, 2026
18 of 27 checks passed
HarishKumarSF4517 pushed a commit to HarishKumarSF4517/maui that referenced this pull request Mar 5, 2026
…rItems (dotnet#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes dotnet#34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
PureWeen pushed a commit that referenced this pull request Mar 11, 2026
…rItems (#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes #34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
github-actions bot pushed a commit that referenced this pull request Mar 11, 2026
…rItems (#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes #34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
@PureWeen PureWeen mentioned this pull request Mar 17, 2026
PureWeen pushed a commit that referenced this pull request Mar 19, 2026
…rItems (#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes #34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
github-actions bot pushed a commit that referenced this pull request Mar 20, 2026
…rItems (#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes #34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
github-actions bot pushed a commit that referenced this pull request Mar 22, 2026
…rItems (#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes #34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
PureWeen added a commit that referenced this pull request Mar 24, 2026
## What's Coming

.NET MAUI inflight/candidate introduces significant improvements across
all platforms with focus on quality, performance, and developer
experience. This release includes 66 commits with various improvements,
bug fixes, and enhancements.


## Activityindicator
- [Android] Implemented material3 support for ActivityIndicator by
@Dhivya-SF4094 in #33481
  <details>
  <summary>🔧 Fixes</summary>

- [Implement material3 support for
ActivityIndicator](#33479)
  </details>

- [iOS] Fix: ActivityIndicator IsRunning ignores IsVisible when set to
true by @bhavanesh2001 in #28983
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] [ActivityIndicator] `IsRunning` ignores `IsVisible` when set to
`true`](#28968)
  </details>

## Button
- [iOS] Button RTL text and image overlap - fix by @kubaflo in
#29041

## Checkbox
- [iOS/MacCatalyst] Fix CheckBox foreground color not resetting when set
to null by @Ahamed-Ali in #34284
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Color of the checkBox control is not properly worked on dynamic
scenarios](#34278)
  </details>

## CollectionView
- [iOS] Fix: CollectionView does not clear selection when SelectedItem
is set to null by @Tamilarasan-Paranthaman in
#30420
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView not being able to remove selected item highlight on
iOS](#30363)
- [[MAUI] Select items traces are
preserved](#26187)
  </details>

- [iOS] CV2 ItemsLayout update by @kubaflo in
#28675
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView CollectionViewHandler2 doesnt change ItemsLayout on
DataTrigger](#28656)
- [iOS CollectionView doesn't respect a change to ItemsLayout when using
Items2.CollectionViewHandler2](#31259)
  </details>

- [iOS][CV2] Fix CollectionView renders large empty space at bottom of
view by @devanathan-vaithiyanathan in
#31215
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] [MacCatalyst] CollectionView renders large empty space at
bottom of view](#17799)
- [[iOS/Mac] CollectionView2 EmptyView takes up large horizontal space
even when the content is
small](#33201)
  </details>

- [iOS] Fixed issue where group Header/Footer template was set to all
items when IsGrouped was true for an ObservableCollection by
@Tamilarasan-Paranthaman in #29144
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Group Header/Footer Repeated for All Items When IsGrouped is
True for ObservableCollection in
CollectionView](#29141)
  </details>

- [Android] Fix CollectionView selection crash with HeaderTemplate by
@NirmalKumarYuvaraj in #34275
  <details>
  <summary>🔧 Fixes</summary>

- [[Bug] [Android] System.ArgumentOutOfRangeException: Index was out of
range. Must be non-negative and less than the size of the collection.
Parameter name: index](#34247)
  </details>

## DateTimePicker
- [iOS] Fix TimePicker AM/PM frequently changes when the app is closed
and reopened by @devanathan-vaithiyanathan in
#31066
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] TimePicker AM/PM frequently changes when the app is closed and
reopened](#30837)
- [Maui 10 iOS TimePicker Strange Characters in place of
AM/PM](#33722)
  </details>

- Android TimePicker ignores 24 hour system setting when using Format
Property - fix by @kubaflo in #28797
  <details>
  <summary>🔧 Fixes</summary>

- [Android TimePicker ignores 24 hour system setting when using Format
Property](#28784)
  </details>

## Drawing
- [iOS, Mac, Windows] GraphicsView: Fix Background/BackgroundColor not
updating by @NirmalKumarYuvaraj in
#31254
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Mac, Windows] GraphicsView does not change the
Background/BackgroundColor](#31239)
  </details>

- [iOS] GraphicsView DrawString - fix by @kubaflo in
#26304
  <details>
  <summary>🔧 Fixes</summary>

- [DrawString not rendering in
iOS.](#24450)
- [GraphicsView DrawString not rendering in
iOS](#8486)
- [DrawString doesn't work on
maccatalyst](#4993)
  </details>

- [Android] - Fix Shadow Rendering For Transparent Fill, Stroke (Lines),
and Text on Shapes by @prakashKannanSf3972 in
#29528
  <details>
  <summary>🔧 Fixes</summary>

- [Ellipse Transparency Not Rendered When Drawing Arc Inside the Ellipse
Using GraphicsView on
Android](#29394)
  </details>

- Revert "[iOS, Mac, Windows] GraphicsView: Fix
Background/BackgroundColor not updating (#31254)" by @Ahamed-Ali via
@Copilot in #34508

## Entry
- [iOS 26] Fix Entry MaxLength not enforced due to new multi-range
delegate by @kubaflo in #32045
  <details>
  <summary>🔧 Fixes</summary>

- [iOS 26 - The MaxLength property value is not respected on an Entry
control.](#32016)
- [.NET MAUI Entry Maximum Length not working on iOS and
macOS](#33316)
  </details>

- [iOS] Fixed Entry with IsPassword toggling loses previously entered
text by @SubhikshaSf4851 in #30572
  <details>
  <summary>🔧 Fixes</summary>

- [Entry with IsPassword toggling loses previously entered text on iOS
when IsPassword is
re-enabled](#30085)
  </details>

## Essentials
- Fix for FilePicker PickMultipleAsync nullable reference type by
@SuthiYuvaraj in #33163
  <details>
  <summary>🔧 Fixes</summary>

- [FilePicker PickMultipleAsync nullable reference
type](#33114)
  </details>

- Replace deprecated NetworkReachability with NWPathMonitor on iOS/macOS
by @jfversluis via @Copilot in #32354
  <details>
  <summary>🔧 Fixes</summary>

- [NetworkReachability is obsolete on iOS/maccatalyst
17.4+](#32312)
- [Use NWPathMonitor on iOS for Essentials
Connectivity](#2574)
  </details>

## Essentials Connectivity
- Update Android Connectivity implementation to use modern APIs by
@jfversluis via @Copilot in #30348
  <details>
  <summary>🔧 Fixes</summary>

- [Update the Android Connectivity implementation to user modern
APIs](#30347)
  </details>

## Flyout
- [iOS] Fixed Flyout icon not updating when root page changes using
InsertPageBefore by @Vignesh-SF3580 in
#29924
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Flyout icon not replaced by back button when root page is
changed using
InsertPageBefore](#29921)
  </details>

## Flyoutpage
- [iOS] Flyout Items Not Displayed in RightToLeft FlowDirection in
Landscape - fix by @kubaflo in #26762
  <details>
  <summary>🔧 Fixes</summary>

- [Flyout Items Not Displayed in RightToLeft FlowDirection on iOS in
Landscape Orientation and Hamburger Icon Positioned
Incorrectly](#26726)
  </details>

## Image
- [Android] Implemented Material3 support for Image by @Dhivya-SF4094 in
#33661
  <details>
  <summary>🔧 Fixes</summary>

- [Implement Material3 support for
Image](#33660)
  </details>

## Keyboard
- [iOS] Fix gap at top of view after rotating device while Entry
keyboard is visible by @praveenkumarkarunanithi in
#34328
  <details>
  <summary>🔧 Fixes</summary>

- [Focusing and entering texts on entry control causes a gap at the top
after rotating simulator.](#33407)
  </details>

## Label
- [Android] Support for images inside HTML label by @kubaflo in
#21679
  <details>
  <summary>🔧 Fixes</summary>

- [Label with HTML TextType does not display images on
Android](#21044)
  </details>

- [fix] ContentLabel Moved to a nested class to prevent CS0122 in
external source generators by @SubhikshaSf4851 in
#34514
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] Building Maui App with sample content results CS0122
errors.](#34512)
  </details>

## Layout
- Optimize ordering of children in Flex layout by @symbiogenesis in
#21961

- [Android] Fix control size properties not available during Loaded
event by @Vignesh-SF3580 in #31590
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView on Android does not provide height, width, logical
children once loaded, works fine on
Windows](#14364)
- [Control's Loaded event invokes before calling its measure override
method.](#14160)
  </details>

## Mediapicker
- [iOS/Android] MediaPicker: Fix image orientation when RotateImage=true
by @michalpobuta in #33892
  <details>
  <summary>🔧 Fixes</summary>

- [MediaPicker.PickPhotosAsync does not preserve image
orientation](#32650)
  </details>

## Modal
- [Windows] Fix modal page keyboard focus not shifting to newly opened
modal by @jfversluis in #34212
  <details>
  <summary>🔧 Fixes</summary>

- [Keyboard focus does not shift to a newly opened modal page: Pressing
enter clicks the button on the page beneath the modal
page](#22938)
  </details>

## Navigation
- [iOS26] Apply view margins in title view by @kubaflo in
#32205
  <details>
  <summary>🔧 Fixes</summary>

- [NavigationPage TitleView iOS
26](#32200)
  </details>

- [iOS] System.NullReferenceException at
NavigationRenderer.SetStatusBarStyle() by @kubaflo in
#29564
  <details>
  <summary>🔧 Fixes</summary>

- [System.NullReferenceException at
NavigationRenderer.SetStatusBarStyle()](#29535)
  </details>

- [iOS 26] Fix back button color not applied for NavigationPage by
@Shalini-Ashokan in #34326
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Color not applied to the Back button text or image on iOS
26](#33966)
  </details>

## Picker
- Fix Picker layout on Mac Catalyst 26+ by @kubaflo in
#33146
  <details>
  <summary>🔧 Fixes</summary>

- [[MacOS 26] Text on picker options are not centered on macOS
26.1](#33229)
  </details>

## Progressbar
- [Android] Implemented Material3 support for ProgressBar by
@SyedAbdulAzeemSF4852 in #33926
  <details>
  <summary>🔧 Fixes</summary>

- [Implement Material3 support for
Progressbar](#33925)
  </details>

## RadioButton
- [iOS, Mac] Fix for RadioButton TextColor for plain Content not working
by @HarishwaranVijayakumar in #31940
  <details>
  <summary>🔧 Fixes</summary>

- [RadioButton: TextColor for plain Content not working on
iOS](#18011)
  </details>

- [All Platforms] Fix RadioButton warning when ControlTemplate is set
with View content by @kubaflo in
#33839
  <details>
  <summary>🔧 Fixes</summary>

- [Seeking clarification on RadioButton + ControlTemplate + Content
documentation](#33829)
  </details>

- Visual state change for disabled RadioButton by @kubaflo in
#23471
  <details>
  <summary>🔧 Fixes</summary>

- [RadioButton disabled UI issue -
iOS](#18668)
  </details>

## SafeArea
- [Android] Fix for TabbedPage BottomNavigation BarBackgroundColor not
extending to system navigation bar by @praveenkumarkarunanithi in
#33428
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TabbedPage BottomNavigation BarBackgroundColor does not
extend to system navigation bar area in Edge-to-Edge
mode](#33344)
  </details>

## ScrollView
- [Android] ScrollView: Fix HorizontalScrollBarVisibility not updating
immediately at runtime by @SubhikshaSf4851 in
#33528
  <details>
  <summary>🔧 Fixes</summary>

- [Runtime Scrollbar visibility not updating correctly on Android and
macOS platforms.](#33400)
  </details>

- Fixed crash when calling ItemsView.ScrollTo on unloaded CollectionView
by @kubaflo in #25444
  <details>
  <summary>🔧 Fixes</summary>

- [App crashes when calling ItemsView.ScrollTo on unloaded
CollectionView](#23014)
  </details>

## Shell
- [Shell] Update logic for iOS large title display in ShellItemRenderer
by @kubaflo in #33246

- [iOS][Shell] Fix navigation lifecycle and back button for More tab (>5
tabs) by @kubaflo in #27932
  <details>
  <summary>🔧 Fixes</summary>

- [OnAppearing and OnNavigatedTo does not work when using extended
Tabbar (tabbar with more than 5 tabs) on
IOS.](#27799)
- [Shell.BackButtonBehavior does not work when using extended Tabbar
(tabbar with more than 5 tabs)on
IOS.](#27800)
- [Shell TabBar More button causes ViewModel command binding
disconnection on back
navigation](#30862)
- [Content page onappearing not firing if tabs are on the more tab on
IOS](#31166)
  </details>

- [iOS 26] Fix tab bar ghosting when navigating from modal to tabbed
Shell content by @SubhikshaSf4851 in
#34254
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Tab bar ghosting issue on iOS 26 (liquid
glass)](#34143)
  </details>

- Fix for Shell tab visibility not updating when navigating back
multiple pages by @BagavathiPerumal in
#34403
  <details>
  <summary>🔧 Fixes</summary>

- [Changing Shell Tab Visibility when navigating back multiple pages
ignores Shell Tab
Visibility](#33351)
  </details>

- [iOS/Mac] Fixed OnBackButtonPressed not firing for Shell Navigation
Bar Button by @Dhivya-SF4094 in
#34401
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] OnBackButtonPressed not firing for Shell Navigation Bar
button](#34190)
  </details>

## Slider
- [iOS] Fix for Slider ThumbImageSource is not centered properly on iOS
26 by @HarishwaranVijayakumar in
#34019
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS 26] Slider ThumbImageSource is not centered
properly](#33967)
  </details>

- [Android] Fix improper rendering of ThumbimageSource in Slider by
@NirmalKumarYuvaraj in #34064
  <details>
  <summary>🔧 Fixes</summary>

- [[Slider] MAUI Slider thumb image is big on
android](#13258)
  </details>

## Stepper
- [iOS] Fix Stepper layout overlap in landscape on iOS 26 by
@Vignesh-SF3580 in #34325
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] D10 - Customize cursor position - Rotating simulator makes
the button and label
overlap](#34273)
  </details>

## SwipeView
- [iOS] SwipeView: Honor FontImageSource.Color in SwipeItem icon by
@kubaflo in #27389
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] SwipeView: SwipeItem.IconImageSource.FontImageSource color
value not honored](#27377)
  </details>

## Switch
- [Android] Fix Switch thumb shadow missing when ThumbColor is set by
@Shalini-Ashokan in #33960
  <details>
  <summary>🔧 Fixes</summary>

- [Android Switch Control Thumb
Shadow](#19676)
  </details>

## Toolbar
- [iOS/Mac Catalyst 26] Fix Shell.ForegroundColor not applied to
ToolbarItems by @SyedAbdulAzeemSF4852 in
#34085
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS26] Shell.ForegroundColor is not applied to
ToolbarItems](#34083)
  </details>

- [Android] VoiceOver on Toolbar Item by @kubaflo in
#29596
  <details>
  <summary>🔧 Fixes</summary>

- [VoiceOver on Toolbar
Item](#29573)
- [SemanticProperties do not work on
ToolbarItems](#23623)
  </details>


<details>
<summary>🧪 Testing (11)</summary>

- [Testing] Additional Feature Matrix Test Cases for CollectionView by
@TamilarasanSF4853 in #32432
- [Testing] Feature Matrix UITest Cases for VisualStateManager by
@LogishaSelvarajSF4525 in #34146
- [Testing] Feature Matrix UITest Cases for Clip by @TamilarasanSF4853
in #34121
- [Testing] Feature matrix UITest Cases for Map Control by
@HarishKumarSF4517 in #31656
- [Testing] Feature matrix UITest Cases for Visual Transform Control by
@HarishKumarSF4517 in #32799
- [Testing] Feature Matrix UITest Cases for Shell Pages by
@NafeelaNazhir in #33945
- [Testing] Feature Matrix UITest Cases for Triggers by
@HarishKumarSF4517 in #34152
- [Testing] Refactoring Feature Matrix UITest Cases for CheckBox Control
by @LogishaSelvarajSF4525 in #34283
- Resolve UI test Build Sample failures - Candidate March 16 by
@Ahamed-Ali in #34442
- Fix the failures in the Candidate branch- March 16 by @Ahamed-Ali in
#34453
  <details>
  <summary>🔧 Fixes</summary>

  - [March 16th, Candidate](#34437)
  </details>
- Fixed the iOS 18.5 Candidate failures (March 16,2026) by @Ahamed-Ali
in #34593
  <details>
  <summary>🔧 Fixes</summary>

  - [March 16th, Candidate](#34437)
  </details>

</details>

<details>
<summary>📦 Other (2)</summary>

- Fixed candidate test failures caused by PR #33428. by @Ahamed-Ali in
#34515
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] On Android, there's a big space at the top for I, M and N2 &
N3](#34509)
  </details>
- Revert "[iOS] Button RTL text and image overlap - fix (#29041)" in
b0497af

</details>

<details>
<summary>📝 Issue References</summary>

Fixes #2574, Fixes #4993, Fixes #8486, Fixes #13258, Fixes #14160, Fixes
#14364, Fixes #17799, Fixes #18011, Fixes #18668, Fixes #19676, Fixes
#21044, Fixes #22938, Fixes #23014, Fixes #23623, Fixes #24450, Fixes
#26187, Fixes #26726, Fixes #27377, Fixes #27799, Fixes #27800, Fixes
#28656, Fixes #28784, Fixes #28968, Fixes #29141, Fixes #29394, Fixes
#29535, Fixes #29573, Fixes #29921, Fixes #30085, Fixes #30347, Fixes
#30363, Fixes #30837, Fixes #30862, Fixes #31166, Fixes #31239, Fixes
#31259, Fixes #32016, Fixes #32200, Fixes #32312, Fixes #32650, Fixes
#33114, Fixes #33201, Fixes #33229, Fixes #33316, Fixes #33344, Fixes
#33351, Fixes #33400, Fixes #33407, Fixes #33479, Fixes #33660, Fixes
#33722, Fixes #33829, Fixes #33925, Fixes #33966, Fixes #33967, Fixes
#34083, Fixes #34143, Fixes #34190, Fixes #34247, Fixes #34273, Fixes
#34278, Fixes #34437, Fixes #34509, Fixes #34512

</details>

**Full Changelog**:
main...inflight/candidate
KarthikRajaKalaimani pushed a commit to KarthikRajaKalaimani/maui that referenced this pull request Mar 30, 2026
…rItems (dotnet#34085)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

### Issue Details

- On iOS 26, setting Shell.ForegroundColor (either at the Shell level or
Page level) no longer applies the specified color to ToolbarItems.
- The toolbar items remain in the default system tint color instead of
respecting the configured foreground color.

### Root Cause

- On iOS 26, Apple's LiquidGlass redesign changed how
UINavigationBar.TintColor propagates to bar button items — it is no
longer automatically inherited.

### Description of Change

- Added UpdateRightBarButtonItemTintColors() method in
ShellPageRendererTracker.cs to explicitly set the TintColor of right bar
button items to the Shell's foreground color for iOS 26+ and Mac
Catalyst 26+. This ensures toolbar items correctly reflect the intended
color.
- Updated property change handlers (HandleShellPropertyChanged,
OnPagePropertyChanged) to call UpdateRightBarButtonItemTintColors() when
relevant properties change, guaranteeing color updates are applied when
needed.


### Issues Fixed
Fixes dotnet#34083

### Validated the behaviour in the following platforms

- [ ] Windows
- [ ] Android
- [x] iOS
- [x] Mac

### Output

| Before | After |
|----------|----------|
| <img
src="https://github.com/user-attachments/assets/dc70555a-7e03-4922-94d5-1f6723c059f1">
| <img
src="https://github.com/user-attachments/assets/30a18bca-103d-4d76-a4ef-956fbbef3fe9">
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-toolbar ToolBar community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-gate-failed AI could not verify tests catch the bug s/agent-review-incomplete AI agent could not complete all phases (blocker, timeout, error) s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) s/agent-suggestions-implemented Maintainer applies when PR author adopts agent's recommendation version/iOS-26

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS26] Shell.ForegroundColor is not applied to ToolbarItems

7 participants