[iOS] Fix for Slider ThumbImageSource is not centered properly on iOS 26

[HarishwaranVijayakumar]

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

• On iOS 26, when a custom ThumbImageSource is set on a Slider control at runtime, the thumb image is not vertically centered on the slider track. The image appears offset (positioned incorrectly).

Root Cause of the issue

• On iOS 26, calling UISlider.SetThumbImage() at runtime no longer results in the thumb position being recalculated. On prior iOS versions, the position was recalculated automatically. The exact internal mechanism that changed is undocumented by Apple, but behavioral evidence confirms the regression: the thumb updates visually but remains at the stale position until user interaction forces a layout pass. Adding an explicit SetNeedsLayout() call restores correct behavior.

Description of Change

• In SliderExtensions.cs, after calling SetThumbImage, the code now explicitly calls SetNeedsLayout() on the UISlider for iOS 26 and above to ensure the thumb position is recalculated, restoring previous runtime behavior.

Issues Fixed

Fixes #33967

Tested the behaviour in the following platforms

• - Windows
• - Android
• - iOS
• - Mac

Output

Before	After

[Copilot]

Pull request overview

This PR fixes an iOS 26-specific issue where the Slider control's ThumbImageSource is not properly centered when set at runtime. The root cause is that iOS 26 changed UISlider's internal behavior - calling SetThumbImage() no longer automatically triggers a layout pass to recalculate the thumb position.

Changes:

• Add explicit SetNeedsLayout() call after SetThumbImage() for iOS 26+ to restore previous runtime behavior
• Add iOS 26-specific visual snapshot baseline for existing test Issue25939

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/Core/src/Platform/iOS/SliderExtensions.cs	Added iOS 26+ version check and explicit SetNeedsLayout() call after SetThumbImage() to trigger layout recalculation
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/SliderShouldChangeThumbImageAndResetIt.png	Added iOS 26-specific visual regression test baseline snapshot

[rmarinho]

🤖 AI Summary

📊 Expand Full Review

---

🔍 Pre-Flight — Context & Validation

---

📝 Review Session — Update valid concern · 927434b

---

Issue: #33967 - [iOS 26] Slider ThumbImageSource is not centered properly
PR: #34019 - [iOS] Fix for Slider ThumbImageSource is not centered properly on iOS 26
Author: HarishwaranVijayakumar (community contributor)
Milestone: .NET 10 SR5
Labels: platform/ios, , area-controls-slider, partner/syncfusion, version/iOS-26community

Issue Summary

On iOS 26, when a custom ThumbImageSource is set on a Slider control at runtime, the thumb image is not vertically centered on the slider track. The image appears offset (positioned incorrectly) and remains at the stale position until a user interaction forces a layout pass.

Root Cause (from PR description)

On iOS 26, UISlider.SetThumbImage() at runtime no longer triggers a layout pass that recalculates the thumb position. On prior iOS versions, this recalculation happened automatically.

Platforms Affected

• Primary: iOS (iOS 26 specific regression)
• Not affected: Android, Windows, macOS

Files Changed

Fix Files

• src/Core/src/Platform/iOS/SliderExtensions. After calling SetThumbImage(), explicitly calls SetNeedsLayout()onUISliderwhen running on iOS 26+. Also addsusing System; import (code style fix).cs

Test Files

• src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/SliderShouldChangeThumbImageAndResetIt. Updated binary snapshot for iOS 26png

Prior Agent Review

A prior agent review was posted on Feb 18, 2026. Key findings from that review:

• FAILED: Test SliderShouldChangeThumbImageAndResetIt takes screenshot AFTER resetting ThumbImageSource, not AFTER setting doesn't capture the bug stateit Gate
• Code style issue: System.OperatingSystem should be OperatingSystem with using **this has since been fixed by PR author**System;
• The test file Issue25939.cs has NOT been updated to capture the post-set state

Code Review Notes

File:Line	Reviewer Says	Status
	Use (remove prefix)	PR author added using System; and removed System. prefix

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #34019	Call SetNeedsLayout() after SetThumbImage() on iOS PENDING (Gate)	SliderExtensions.cs (+7)	iOS 26 version-guarded; code style fixed	26+

---

🚦 Gate — Test Verification

---

📝 Review Session — Update valid concern · 927434b

---

** FAILED (Tests don't catch the bug)Result:**
Platform: iOS
Mode: Full Verification

Test Execution Results

Check	Expected	Actual	Result
Tests WITHOUT fix	FAIL		PASS
Tests WITH fix	PASS	PASS

Root Cause of Gate Failure

The test SliderShouldChangeThumbImageAndResetIt (Issue25939) does NOT catch the bug:

1. Bug behavior: On iOS 26, when ThumbImageSource is set at runtime via SetThumbImage(), the thumb's position is not recalculated, resulting in incorrect vertical positioning.

2. What the test does:
   sets ThumbImageSource = "coffee.png" on SliderControl and SliderControl2
   sets SliderControl2.ThumbImageSource = null

   • taken AFTER the reset, when thumb has returned to defaultVerifyScreenshot()

3. Why test passes without fix: After resetting ThumbImageSource to null, the thumb returns to default (which is unaffected by the bug). The screenshot is taken in the post-reset state, which doesn't show the bug.

4. What test SHOULD do: Take a screenshot AFTER setting ThumbImageSource (before resetting), capturing the mispositioned thumb state that the fix corrects.

Verdict

The existing test does not detect the iOS 26 thumb positioning regression. A proper test must capture the slider state AFTER setting ThumbImageSource (before any reset).FAILED Gate

---

🔧 Fix — Analysis & Comparison

---

📝 Review Session — Update valid concern · 927434b

---

Fix Candidates

#	Source	Approach	Test Result	Files Changed	Notes
PR	PR #34019	Add SetNeedsLayout() after SetThumbImage() on iOS SKIPPED (Gate failed)	SliderExtensions.cs	Gate tests don't catch the bug	failed 26+

Exhausted: N/ Phase 3 skipped because FAILEDGate A

Reason for Skip: The Gate phase confirmed the existing test (SliderShouldChangeThumbImageAndResetIt) does NOT detect the iOS 26 thumb positioning bug. Without a valid test harness to run fix attempts against, meaningful empirical comparison of alternative fixes is not possible.

Selected Fix: PR's fix remains the candidate under review. Technical analysis indicates it is conceptually correct (SetNeedsLayout() is the standard iOS API for invalidating view layout).

---

📋 Report — Final Recommendation

---

📝 Review Session — Update valid concern · 927434b

---

Final Recommendation: REQUEST CHANGES##

Summary

OperatingSystem) has been fixed by the author.

---

Root Cause

iOS 26 changed UIKit behavior: UISlider.SetThumbImage() at runtime no longer automatically triggers a layout recalculation that repositions the thumb. As a result, after setting a custom thumb image dynamically, the slider thumb remains at an incorrect (uncentered) vertical position until a user interaction forces a layout pass. The fix correctly calls uiSlider.SetNeedsLayout() after SetThumbImage() to explicitly request layout, restoring expected centering behavior.

---

Fix Quality

The PR's fix is technically sound:

• Correctly guards with OperatingSystem.IsIOSVersionAtLeast(26) to limit the change to iOS 26+
• Applies SetNeedsLayout() in both paths ( when setting an image AND when nullifying itUpdateThumbImageSourceAsync)
• SetNeedsLayout() is the canonical iOS API for invalidating view layout
• The using System; style issue has been resolved

---

Issue to Address

Tests Don't Catch the Bug (Critical)

Issue: The test SliderShouldChangeThumbImageAndResetIt (Issue25939.cs) calls VerifyScreenshot() after resetting ThumbImageSource back to null, not after setting it. The positioning bug only manifests when ThumbImageSource is set (the thumb appears mispositioned vertically). After the reset, the slider returns to the default thumb which is unaffected by the bug.

Evidence: Gate verification tests PASS without the fix, PASS with the fix. The test provides zero regression protection.confirmed

Required change: Add a test step that takes a screenshot after setting ThumbImageSource (before resetting). The snapshot taken at that point should fail without the SetNeedsLayout() call on iOS 26.

Suggested fix for Issue25939.cs:

[Test]
[Category(UITestCategories.Slider)]
public void SliderShouldChangeThumbImageAndResetIt()
{
    App.WaitForElement("ChangeThumbImageSourceButton");
    App.Click("ChangeThumbImageSourceButton");
    // NEW: Take screenshot HERE to verify thumb is centered after setting ThumbImageSource
    VerifyScreenshot();
    App.Click("ResetThumbImageSourceButton");
    VerifyScreenshot("SliderShouldChangeThumbImageAndResetIt_After_Reset");
}

Or alternatively, add a new separate test method:

[Test]
[Category(UITestCategories.Slider)]
public void SliderThumbImageShouldBeCenteredAfterSet()
{
    App.WaitForElement("ChangeThumbImageSourceButton");
    App.Click("ChangeThumbImageSourceButton");
    VerifyScreenshot();
}

---

Phase Summary

Phase	Result

---

For the PR Author

The core fix approach (SetNeedsLayout() after SetThumbImage() on iOS 26+) is correct and the code style is clean. The only remaining change needed:

Update the test to take a screenshot immediately after setting ThumbImageSource, so the test actually fails on iOS 26 without the fix and passes with it. A new snapshot for ios-26 should also be added for that verification step.

---

📋 Expand PR Finalization Review

---

Title: ✅ Good

Current: [iOS] Fix for Slider ThumbImageSource is not centered properly on iOS 26

Description: ✅ Good

Description needs updates. See details below.

✨ Suggested PR Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

On iOS 26, when a custom ThumbImageSource is set on a Slider control at runtime, the thumb image is not vertically centered on the slider track. The image appears offset until the user interacts with the slider (which forces a layout pass).

Root Cause

On iOS 26, calling UISlider.SetThumbImage() at runtime no longer triggers the internal layout pass that recalculates the thumb position. On prior iOS versions, this recalculation happened automatically. The exact internal mechanism that changed is undocumented by Apple, but the behavioral regression is clear. Adding an explicit SetNeedsLayout() call after SetThumbImage() restores the correct behavior.

Description of Change

In SliderExtensions.cs, after calling SetThumbImage() (both when setting an image and when clearing it), the code now calls SetNeedsLayout() on the UISlider when running on iOS 26 or later. This is gated with OperatingSystem.IsIOSVersionAtLeast(26) to avoid unnecessary layout passes on older iOS versions where the automatic recalculation still works.

No behavior change on Android, Windows, or macOS.

Issues Fixed

Fixes #33967

Platforms Tested

• iOS (fix verified — thumb image now centers correctly at runtime on iOS 26)
• Android (no change in behavior)
• Windows (no change in behavior)
• Mac (no change in behavior)

Output

Before (iOS 26)	After (iOS 26)

Code Review: ✅ Passed

Code Review — PR #34019

Changed Files

1. src/Core/src/Platform/iOS/SliderExtensions.cs — 9 additions, 1 deletion
2. src/Controls/tests/TestCases.iOS.Tests/snapshots/ios-26/SliderShouldChangeThumbImageAndResetIt.png — snapshot update

---

Code Review Findings

✅ No Critical Issues

🟡 Minor Suggestion

Missing newline at end of file

• File: src/Core/src/Platform/iOS/SliderExtensions.cs
• Problem: The file does not end with a newline character. The original file already had this issue, and the change preserves it (visible as \ No newline at end of file in the diff).
• Recommendation: Add a newline at the end of the file to follow standard file formatting conventions.

---

✅ Looks Good

• Correct version-gating: OperatingSystem.IsIOSVersionAtLeast(26) is the modern, correct .NET API for platform version checks. Avoids unnecessary SetNeedsLayout() calls on iOS versions where the layout pass already happens automatically.

• Placement of SetNeedsLayout(): The call is placed after both code paths in UpdateThumbImageSourceAsync — the image-set path (thumbImage != null) and the image-clear/reset path (else branch). This is correct because both setting and clearing the thumb image trigger the same stale-position regression on iOS 26.

• Minimal and targeted fix: The change is a single well-placed call with a clear comment explaining the iOS 26 behavioral regression. No over-engineering.

• Comment quality: The inline comment accurately describes the problem and the fix, providing context for future maintainers:

  // On iOS 26+, SetThumbImage() no longer triggers a layout pass that recalculates
  // the thumb position at runtime. Explicitly call SetNeedsLayout() to restore this.

• using System; correctly added: OperatingSystem is in System namespace; the import was appropriately added.

• Snapshot updated: The SliderShouldChangeThumbImageAndResetIt.png snapshot for ios-26 was updated, confirming the existing UI test was re-baselined with the correct (fixed) behavior.

---

Summary

The fix is clean, minimal, and well-explained. The only actionable item is the minor style issue with the missing EOF newline, which pre-existed in the file. No bugs or logic errors found.

---

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 34019

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 34019"