Fix the failures in the Candidate branch- March 16 by Ahamed-Ali · Pull Request #34453 · dotnet/maui

Ahamed-Ali · 2026-03-12T14:33:39Z

Root Cause of the issue

The failing test: SetVisibility(Visibility.Collapsed) device test on iOS.

Why it fails: PR [iOS] Fix: ActivityIndicator IsRunning ignores IsVisible when set to true #28983's fix maps Visibility → MapIsRunning in
ActivityIndicatorHandler, which bypasses the standard
ViewExtensions.UpdateVisibility path. The standard path calls Collapse() to
add a CollapseConstraint (an NSLayoutConstraint that zeros the view's size).
The PR's UpdateIsRunning only sets Hidden = true — it never calls Collapse()
Crash in the FeatureMatrix Navigation Page Scenario in the iOS 26
PR [iOS 26] Fix back button color not applied for NavigationPage #34326 added an else block in UpdateBarTextColor() that explicitly sets BackButtonAppearance = null, BackIndicatorImage = null, and BackIndicatorTransitionMaskImage = null on the navigation bar when no custom color is applied. On iOS versions before 26, assigning null to these properties was treated as "use system defaults." On iOS 26, the Liquid Glass rendering pipeline reads these properties during push/pop navigation transitions and throws an exception when it encounters an explicit null — it expects either an unset property or a valid object. Since useCustomColor is false by default (no IconColor set), this crashes on every standard page navigation.
Setting ThumbTintList = null in the else block removes the tint entirely, causing the thumb to appear white instead of the default blue, because SwitchCompat does not re-resolve its theme colors once the tint list is cleared.
SetAdjustViewBounds(false) was being applied to all images regardless of their Aspect value. When this property is false, Android’s ImageView does not resize itself based on the image’s intrinsic aspect ratio and instead expands to fill the available space. As a result, an Image control with the default AspectFit setting ignored its height constraint and overflowed its container, causing the image to appear taller than expected in the screenshot test.(LoadAndVerifyGif, ThemeRelated feature tests)
PR [iOS] Fixed issue where group Header/Footer template was set to all items when IsGrouped was true for an ObservableCollection #29144 changed the group-detection guard in ObservableGroupedSource (iOS and Android) from is IEnumerable to is ICollection to prevent strings (which implement IEnumerable) from being treated as groups.
While the intent was correct, the change was too broad. Custom group types that implement only IEnumerable were also excluded. As a result, _groupCount became zero on iOS and _groups remained empty on Android, causing grouped CollectionView rendering failures and IndexOutOfRangeException during Add/Remove operations.
StepperHandler.iOS.cs compiles for both iOS and Mac Catalyst. On Mac Catalyst / macOS 26, OperatingSystem.IsIOS() and IsIOSVersionAtLeast(26) both return true, and the screen is always landscape. As a result, the 20pt glass pill compensation was incorrectly applied, inflating GetDesiredSize(1,1) to width = 21. (Native View Bounding Box is not empty - device Test failures)
In PR [Android] Fix for TabbedPage BottomNavigation BarBackgroundColor not extending to system navigation bar #33428, the WindowInsetsCompat.Builder block in MauiWindowInsetListener.ApplyDefaultWindowInsets was simplified to return insets; to standardize inset handling. This change was unrelated to the actual fix for [Android] TabbedPage BottomNavigation BarBackgroundColor does not extend to system navigation bar area in Edge-to-Edge mode #33344, which only required passing the bottom inset through as unconsumed.
As part of that refactor, top inset consumption was also removed, changing the prior contract where the top inset was consumed when appBarHasContent = true. While normal safe-area scenarios worked correctly, transient layout states (e.g., temporary Height = 0 during keyboard dismissal, rotation, animation, or dynamic item generation) triggered a second inset dispatch. In those moments, the top inset satisfied the overlap condition and was applied to content before SafeAreaExtensions could normalize it, causing test failures. Bottom insets did not regress because their overlap condition cannot be met in the same transient state. (EntryScrollTest, HorizontalStackLayout_Spacing_WithLandscape, VerticalStackLayout_Spacing_WithLandscape and so on failures)

Description of Change

Handles the three Visibility cases the same way as ViewExtensions.UpdateVisibility:

Visible: Calls Inflate() (restores layout size) and sets Hidden = false — identical to UpdateVisibility. Additionally starts/stops the animation based on IsRunning.
Hidden: Calls Inflate() (preserves layout space) and sets Hidden = true — identical to UpdateVisibility. The indicator keeps its layout footprint but is invisible.
Collapsed: Sets Hidden = true and calls Collapse() (zeros out layout size via constraints) — identical to UpdateVisibility. The indicator is both invisible and takes up no space.

Removed the else block entirely. When no custom color is applied, these properties should remain untouched. The system defaults work correctly on their own — there is no need to explicitly reset them to null
Removed the else block from UpdateThumbColor in SwitchExtensions.cs. The default thumb color is managed by SwitchCompat internally from the Material theme, so no explicit reset is needed.
Restored the correct logic in ImageViewExtensions.UpdateAspect to call SetAdjustViewBounds based on the image’s Aspect value:
The guard has been updated from is ICollection to is IEnumerable && not string in the ObservableGroupedSource implementations for both iOS and Android (GroupsCount(), UpdateGroupTracking(), Add(), Remove()).
This change specifically excludes string while allowing legitimate custom group types that implement only IEnumerable. The fix restores the behavior for Issue22320 while keeping all Issue29141 scenarios working correctly.
-Added !OperatingSystem.IsMacCatalyst() to the guard condition in GetDesiredSize, restricting the 20pt compensation to real iOS 26+ only — as intended in the original PR comment.
Restored the original behavior by consuming the top inset when appBarHasContent = true, while continuing to pass the bottom inset through unconsumed (the only change required for [Android] TabbedPage BottomNavigation BarBackgroundColor does not extend to system navigation bar area in Edge-to-Edge mode #33344). This retains the Android edge-to-edge fix and restores deterministic safe-area handling.

Testing related description of change

EditorNoOverlapAfterRotateToLandscape, EditorNoOverlapAfterRotateToPortrait, EntryFocusedShouldNotCauseGapAfterRotation Added cropLeft to remove the navbar on Android and re-saved the image due to entry text changes in this commit – 8d17a6d, 91047fb.

DrawStringShouldDrawText – The automation ID set to GraphicsView was not found by Appium on the Windows platform, so a test condition was added for Windows to take the image directly instead of waiting for the GraphicsView.

Added the base images for iOS 26 and Mac that were not added previously.

Re-saved the images that failed due to the wrong iOS version image being added in the PR.

Re-saved the test images that failed due to this fix PR: #31254 — e.g., GraphicsViewFeatureTests and others.

Resaved the slider-related test images due to this fix PR — #34064.

Re-saved the CollectionViewShouldChangeItemsLayout due to a slight difference between CV1 and CV2. Since the fix is related to CV2, the XAML class was explicitly set to CV2 and then re-saved.

Issues Fixed

Fixes #34437

Tested the behaviour in the following platforms

iOS
Mac

sheiksyedm · 2026-03-12T14:43:09Z

/azp run maui-pr-uitests,maui-pr-devicetests

azure-pipelines · 2026-03-12T14:43:39Z